Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move button variables to variables? #2897

Closed
easherma opened this issue Jan 17, 2019 · 2 comments
Closed

Move button variables to variables? #2897

easherma opened this issue Jan 17, 2019 · 2 comments
Assignees
@thisisdano
Labels
Type: Enhancement An improvement to existing code

Comments

@easherma
Copy link

uswds/src/stylesheets/elements/_buttons.scss

Line 3 in e57e5ea

$button-stroke: inset 0 0 0 2px;

Seems like variables meant to be modified would all be in the same place?
@thisisdano thisisdano self-assigned this Jan 31, 2019
@thisisdano thisisdano added Type: Enhancement An improvement to existing code 2.0 labels Jan 31, 2019
@thisisdano
Copy link
Member

Yeah. This is something we should do in USWDS 2.0.

@thisisdano thisisdano mentioned this issue Feb 1, 2019
Merged
@thisisdano
Copy link
Member

Implemented for USWDS 2.0 here: #2901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thisisdano thisisdano

Labels
Type: Enhancement An improvement to existing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@easherma @thisisdano