Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"site is secure" and ".gov means it's official" icons filling page when printing #2883

Closed
suprenant opened this issue Nov 26, 2018 · 4 comments

Comments

@suprenant
Copy link

When I visit https://join.tts.gsa.gov/ as well as some 18F guides (including the Agile Guide) and print, I notice that the lock and courthouse icons fill an entire page.

I do not notice this on some other sites using USWDS.

From a colleague in TTS Slack:
It would appear nothing is constraining the SVG sizes. I wonder where the shared print style for the guides comes from

screen shot 2018-11-16 at 10 51 09 am
screen shot 2018-11-16 at 10 51 06 am

@greensteph
Copy link

Hi @suprenant thanks for submitting this issue. We are exploring how to best provide a solution as well as improving print styling overall.

@suprenant
Copy link
Author

@greensteph sounds good, thanks for the update. I'll look forward to seeing what might come from this. If you ever want any feedback or anything, please let me know.

@karareinsel
Copy link

@greensteph we're seeing this issue on the TTS Join site well so I wanted to see if any progress has been made on the bug?

@thisisdano
Copy link
Member

This is fixed in USWDS 2.0 with #2910.
Once the dust clears from 2.0, we can look into getting this into a 1.x release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants