Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove _uswds-theme.scss from theme files #2822

Closed
thisisdano opened this issue Oct 5, 2018 · 1 comment
Closed

Remove _uswds-theme.scss from theme files #2822

thisisdano opened this issue Oct 5, 2018 · 1 comment
Assignees
@thisisdano
Labels
Context: Sass Issue is in Sass Type: Enhancement An improvement to existing code

Comments

@thisisdano
Copy link
Member

This file is just collecting the individual settings files, and this level of abstraction doesn't really make a lot of sense. We can and should just include the settings files in styles.scss
@thisisdano thisisdano added Type: Enhancement An improvement to existing code Context: Sass Issue is in Sass 2.0 labels Oct 5, 2018
@thisisdano thisisdano self-assigned this Oct 5, 2018
@thisisdano thisisdano mentioned this issue Oct 7, 2018
Merged
@thisisdano
Copy link
Member Author

Fixed in #2830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thisisdano thisisdano

Labels
Context: Sass Issue is in Sass Type: Enhancement An improvement to existing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thisisdano