Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts usa-alert-slim version doesn't resize the icon. #2755

Closed
nolawi opened this issue Sep 19, 2018 · 5 comments
Closed

Alerts usa-alert-slim version doesn't resize the icon. #2755

nolawi opened this issue Sep 19, 2018 · 5 comments
Assignees

Comments

@nolawi
Copy link

nolawi commented Sep 19, 2018

Description

The icons in this alerts version does not reduce the size of the icon.

screen shot 2018-09-19 at 2 58 39 pm

Propose screen shot 2018-09-19 at 11 00 44 am

.usa-alert-slim { background-size: Xrem;

Location

@thisisdano
Copy link
Member

Interesting — I'm game to make it smaller. @maya what do you think?

@nolawi
Copy link
Author

nolawi commented Sep 20, 2018

@thisisdano if its a go I can do it and send PR to you.

@maya
Copy link
Contributor

maya commented Sep 20, 2018

Is the suggestion to reduce the icon size in usa-alert-slim or for all the alerts at small screen sizes or both?

@nolawi
Copy link
Author

nolawi commented Sep 20, 2018

Just the slim version; since the font size is constant on all alerts regardless of screen size, it doesn't make sense to resize the icon on the default.

@maya maya self-assigned this Mar 12, 2019
@maya
Copy link
Contributor

maya commented Mar 12, 2019

This was done in #2946. Thanks @nolawi for bringing this up!

@maya maya closed this as completed Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants