Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding a lang theme type family #2683

Closed
thisisdano opened this issue Aug 16, 2018 · 1 comment
Closed

Consider adding a lang theme type family #2683

thisisdano opened this issue Aug 16, 2018 · 1 comment
Assignees
@thisisdano
Labels
Context: Sass Issue is in Sass Type: Enhancement An improvement to existing code

Comments

@thisisdano
Copy link
Member

We have four available theme type families:

  • sans
  • serif
  • cond
  • mono

This should be reasonable for most projects, but I could see a possible need for some kind of language-specific faces that might not easily fit into these categories. We could add lang as a fifth. This wouldn't cost much, as we already support cond but have no supported condensed faces.
@thisisdano thisisdano added the 2.0 label Aug 16, 2018
@thisisdano thisisdano self-assigned this Aug 16, 2018
@thisisdano thisisdano added Type: Enhancement An improvement to existing code Context: Sass Issue is in Sass labels Oct 9, 2018
@thisisdano thisisdano mentioned this issue Feb 22, 2019
Merged
@thisisdano
Copy link
Member Author

Added in #2919

@thisisdano thisisdano mentioned this issue Mar 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thisisdano thisisdano

Labels
Context: Sass Issue is in Sass Type: Enhancement An improvement to existing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thisisdano