From d795404aa9deaeb94e000da7174b8268afae0162 Mon Sep 17 00:00:00 2001 From: Maya Benari Date: Fri, 8 Mar 2019 16:56:23 -0800 Subject: [PATCH 1/3] Update external link to hyphen --- src/components/01-type/links.njk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/01-type/links.njk b/src/components/01-type/links.njk index 250bfd3cc7..5cdf672f7c 100755 --- a/src/components/01-type/links.njk +++ b/src/components/01-type/links.njk @@ -2,7 +2,7 @@

This is a visited link.

-

This is a link that goes to an external website.

+

This is a link that goes to an external website.

This is a text link on a dark background.

From 9d4139efbf25cb8df12e2eaa95b845a4eefd62c2 Mon Sep 17 00:00:00 2001 From: "Dan O. Williams" <11464021+thisisdano@users.noreply.github.com> Date: Mon, 11 Mar 2019 09:22:34 -0700 Subject: [PATCH 2/3] Use BEM for external link; use modular link--alt --- src/components/01-type/links.njk | 2 +- src/stylesheets/elements/_typography.scss | 9 +++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/components/01-type/links.njk b/src/components/01-type/links.njk index 5cdf672f7c..272af34dae 100755 --- a/src/components/01-type/links.njk +++ b/src/components/01-type/links.njk @@ -2,7 +2,7 @@

This is a visited link.

-

This is a link that goes to an external website.

+

This is a link that goes to an external website.

This is a text link on a dark background.

diff --git a/src/stylesheets/elements/_typography.scss b/src/stylesheets/elements/_typography.scss index 65a5359219..e83e760360 100644 --- a/src/stylesheets/elements/_typography.scss +++ b/src/stylesheets/elements/_typography.scss @@ -41,14 +41,15 @@ html { // [href^="http:"]:not([href*="my-domain.com"]) // [href^="https:"]:not([href*="my-domain.com"]) -.usa-external-link { +.usa-link--external { @include external-link(external-link, external-link-hover); -} -.usa-external-link-alt { - @include external-link(external-link-alt, external-link-alt-hover); + &.usa-link--alt { + @include external-link(external-link-alt, external-link-alt-hover); + } } + // Remove user agent styles cite, From ecdc709f76e6f52e3a84da2454dfe11351b15746 Mon Sep 17 00:00:00 2001 From: "Dan O. Williams" <11464021+thisisdano@users.noreply.github.com> Date: Mon, 11 Mar 2019 09:30:35 -0700 Subject: [PATCH 3/3] Remove stray extra line --- src/stylesheets/elements/_typography.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/src/stylesheets/elements/_typography.scss b/src/stylesheets/elements/_typography.scss index e83e760360..d5220ab1c5 100644 --- a/src/stylesheets/elements/_typography.scss +++ b/src/stylesheets/elements/_typography.scss @@ -49,7 +49,6 @@ html { } } - // Remove user agent styles cite,