From d64c9f0b3d84b1df313875abc7b3dca1a2885ab5 Mon Sep 17 00:00:00 2001 From: "Dan O. Williams" <11464021+thisisdano@users.noreply.github.com> Date: Fri, 15 Feb 2019 09:23:18 -0800 Subject: [PATCH 1/2] Use `all` for media queries instead of screen only --- src/stylesheets/core/mixins/_at-media.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/stylesheets/core/mixins/_at-media.scss b/src/stylesheets/core/mixins/_at-media.scss index ddd3000cc9..007f9e9826 100644 --- a/src/stylesheets/core/mixins/_at-media.scss +++ b/src/stylesheets/core/mixins/_at-media.scss @@ -13,7 +13,7 @@ @else { @warn '`#{$bp}` is not a valid USWDS project breakpoint. Valid values: #{map-keys($our-breakpoints)}'; } - @media screen and (min-width: #{$bp}) { + @media all and (min-width: #{$bp}) { @content; } } @@ -33,7 +33,7 @@ @else { @warn '`#{$bp}` is not a valid USWDS project breakpoint. Valid values: #{map-keys($our-breakpoints)}'; } - @media screen and (max-width: #{$bp}) { + @media all and (max-width: #{$bp}) { @content; } } From bb97178049c85dda7e5142ef7741bb42453898a3 Mon Sep 17 00:00:00 2001 From: "Dan O. Williams" <11464021+thisisdano@users.noreply.github.com> Date: Fri, 15 Feb 2019 13:51:28 -0800 Subject: [PATCH 2/2] Add space after comment --- src/stylesheets/core/mixins/_at-media.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/src/stylesheets/core/mixins/_at-media.scss b/src/stylesheets/core/mixins/_at-media.scss index 007f9e9826..3a9814fcc7 100644 --- a/src/stylesheets/core/mixins/_at-media.scss +++ b/src/stylesheets/core/mixins/_at-media.scss @@ -1,4 +1,5 @@ // Mobile-first media query helper + @mixin at-media($bp) { $quoted-bp: smart-quote($bp); $our-breakpoints: map-deep-get($system-properties, breakpoints, standard);