Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible issue with overriding settings in settings/_uswds-theme-typography.scss #839

Closed
fubario opened this issue Dec 18, 2019 · 1 comment · Fixed by #840
Closed

Possible issue with overriding settings in settings/_uswds-theme-typography.scss #839

fubario opened this issue Dec 18, 2019 · 1 comment · Fixed by #840

Comments

@fubario
Copy link

fubario commented Dec 18, 2019

Hello, typography settings refers to an unused variable $theme-title-font-size, which has been renamed to $theme-display-font-size

$theme-title-font-size: '3xl';

This is the commit where it was renamed:
uswds/uswds@a0d413d?diff=unified#diff-69dac101ebc9ed204164c212c138c8bd

@thisisdano
Copy link
Member

Good catch. We're working on an improvement that should better surface these issues in uswds/uswds#3261

But for now, I'll go in and fix this — and see what happens!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants