Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aliases.drushrc.php.stub is not PHP 8 compatible #19

Open
Leksat opened this issue Feb 24, 2022 · 1 comment
Open

aliases.drushrc.php.stub is not PHP 8 compatible #19

Leksat opened this issue Feb 24, 2022 · 1 comment

Comments

@Leksat
Copy link

Leksat commented Feb 24, 2022

Describe the bug

There is a comparison happening here: https://github.com/uselagoon/lagoon/blob/9f9c6cbf6fcd66819829074ade5b404cd5a0050f/services/drush-alias/web/aliases.drushrc.php.stub#L41

In PHP 8 it works in a different way: https://3v4l.org/PMomq (because of this change in PHP 8)

Screen Shot 2022-02-24 at 13 05 21

To Reproduce

Steps to reproduce the behavior:

  1. Get a project using the stub file (https://github.com/amazeeio/drupal-setting-files/blob/master/Drupal8/drush/aliases.drushrc.php)
  2. Upgrade the project to PHP 8

Drush aliases do not work.

Expected behavior

Drush aliases work.

Additional context

The stub file is not needed on projects using https://github.com/amazeeio/drupal-integrations, but will provide a PR anyway.

@tobybellwood
Copy link
Member

code change is
if ( (int)DRUSH_VERSION >= 9 ) {

@tobybellwood tobybellwood transferred this issue from uselagoon/lagoon Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants