Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint using Mypy #155

Closed
danieleades opened this issue Sep 14, 2020 · 1 comment
Closed

Lint using Mypy #155

danieleades opened this issue Sep 14, 2020 · 1 comment

Comments

@danieleades
Copy link
Contributor

i'm playing around using mypy to do some type checking on this branch

by refactoring some of the imports, i've got the number of type errors down from ~60 to 6.

this branch depends on #154

It would also be nice to add type annotations throughout the codebase, since I can see needs is already targeting python >= 3.5. This can be adopted incrementally.

@danieleades danieleades mentioned this issue Sep 17, 2020
@danieleades
Copy link
Contributor Author

i think i'll close this.

in its current state, mypy can't be used effectively on this repo.

hopefully can revisit later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant