Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade app to Vue.js 3 #45

Closed
cmroberts opened this issue Mar 9, 2022 · 2 comments
Closed

Upgrade app to Vue.js 3 #45

cmroberts opened this issue Mar 9, 2022 · 2 comments

Comments

@cmroberts
Copy link
Contributor

This will be a fairly involved port but we should really be running on a more modern framework in 2022.

This will also enable us to tackle #23; currently most upgrades are not compatible with the version of Vue + Node.js we are using.

@Rapol
Copy link
Contributor

Rapol commented Mar 14, 2022

https://github.com/usdigitalresponse/usdr-gost/tree/45-upgrade-app-to-vuejs

After all that compilation is successful and it is served but a runtime error happens:

Uncaught (in promise) TypeError: 'set' on proxy: trap returned falsish for property 'id'
    at deepMergeData (vue.runtime.esm-bundler.js?cdfc:4751:1)
    at deepMergeData (vue.runtime.esm-bundler.js?cdfc:4748:1)
    at Proxy.mergedDataFn (vue.runtime.esm-bundler.js?cdfc:5171:1)
    at applyOptions (vue.runtime.esm-bundler.js?cdfc:4910:1)
    at finishComponentSetup (vue.runtime.esm-bundler.js?cdfc:10471:1)
    at setupStatefulComponent (vue.runtime.esm-bundler.js?cdfc:10368:1)
    at setupComponent (vue.runtime.esm-bundler.js?cdfc:10298:1)
    at mountComponent (vue.runtime.esm-bundler.js?cdfc:7592:1)
    at processComponent (vue.runtime.esm-bundler.js?cdfc:7563:1)
    at patch (vue.runtime.esm-bundler.js?cdfc:7155:1)

Google search didnt help. Next step would be to upgrade vuex and vue-router. If that still doesnt solve the issue I would think it might help to start a fresh vue 3 project and migrate portions of the app until we get the error.

@cmroberts
Copy link
Contributor Author

The team triaged this in the volunteer standup this week and decided to deprioritize this for now. We'll plan to ship with Vue.js 2 / node 14 for the near term and will plan to close dependabot pull requests that aren't compatible with this set of artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants