New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preparing to test action with web drivers! #96
Conversation
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
woo it worked! Okay @tinosulzer @rootwork would you care to test your repos against this branch? It should be the same urlchecker-action, but |
It's definitely working better. I get some failed URLs but they're all because of timeouts, I think. I did notice this:
on several of the checks. Not sure if that's significant. On the second run I didn't see that error message, and there were fewer URLs failing, all still because of timeouts I think. (Edit: The last URL, the Internet Archive one, is legitimately broken because of a typo. All the other failed ones should work though.) |
Let me take a look! |
okay @rootwork give it another try (e.g., just click re-run) ! It looks like a tab crashed and then those errors started happening, so I am trying two things:
|
Got the [Edit: Just saw your new message; testing again.] |
okay going to push a fix for the ports in a second... will test here first. |
oup I see your message! I'll wait for your test before pushing changes! |
Almost all the failing URLs are now just Twitter. |
I think we're getting closer! Let me manually test that smaller list that are still failing, will report back. |
okay new changes are in - urlstechie/urlchecker-python@a9bf156 let's do another re-run! (and thank you for doing this to help!) |
It passed! Woo! Thank you for ALL your work on this. I really appreciate it! |
Woo! Most definitely! I'm so glad to find a solution for these tricky urls too! I'm going to release urlchecker-python, and then I'll be back here to finish up. Thank you for all the testing @rootwork ! |
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Worked for me too :) https://github.com/pybamm-team/PyBaMM/runs/7491354319?check_suite_focus=true Thanks! |
When I tried to use the released version 0.0.31, it passed but didn't seem to check anything https://github.com/pybamm-team/PyBaMM/runs/7491390710?check_suite_focus=true |
@tinosulzer can you give me more detail? I see a list of a ton of URLs at that action linked. |
Yes you're right, I don't know why I thought that. Thanks again! |
ok phew! |
This will close #93
Signed-off-by: vsoch vsoch@users.noreply.github.com