Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests trigger on action release #66

Closed
wants to merge 2 commits into from

Conversation

@vsoch
Copy link
Collaborator

vsoch commented Apr 18, 2020

This shouldn't be necessary if we put the tests here, where they should be :)

@vsoch
Copy link
Collaborator

vsoch commented Apr 18, 2020

This also isn't logical because it's going to fire testing after a release... we need to test for any PR for urlchecker-action. Here is what you should do.

  • Take the tests that you are adding to urlchecker-test-repo and add them alongside the tests we have here, which are already started in main.yml
  • those tests are already running on PR, which is what we want
  • close both these PRs.

If you ever aren't sure about an issue (e.g., the one you wanted to address here) please ping me on the issue and we can talk about it first! I think the work you did will still be useful for the urlchecker-test-repo, you just need to move the content into a PR over here.

@vsoch vsoch closed this Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional tests needed for .github workflow
2 participants