Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional tests needed for .github workflow #43

Open
vsoch opened this issue Apr 5, 2020 · 4 comments
Open

Additional tests needed for .github workflow #43

vsoch opened this issue Apr 5, 2020 · 4 comments
Assignees

Comments

@vsoch
Copy link
Collaborator

vsoch commented Apr 5, 2020

Currently, we do one run that does basic checks for the testing repository. We would want to add additional runs that:

  • use save and verify that the file exists
  • use cleanup to verify that the repository is deleted
  • others that might be useful

We absolutely don't want any PRs being merged that possibly break any previous functionality.

@SuperKogito
Copy link
Member

yes, the coverage is quite low atm and I intend to work on improving it.
I can take on this if you don't mind.

@vsoch
Copy link
Collaborator Author

vsoch commented Apr 5, 2020

Yes that would be great! And don't forget to do feature branch and PR, and I'll be sure to give a speedy review :)

@vsoch
Copy link
Collaborator Author

vsoch commented Apr 13, 2020

@SuperKogito we need to prioritize this issue, over any changes to urlchecker-python. We need to make sure that the action is working for multiple different use cases, and we don't run into issues like we did with the cleanup arg!

@SuperKogito
Copy link
Member

I agree, I am working on a PR for the test-repo that hopefully will solve this, but testing the changes might become messy because I want to trigger the tests following the action releases. It would be better to do it without a release but I am not sure if that is even possible. If you have better ideas on how to test the action, I am all ears :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants