Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the use of default OpenSSL ciphers #3107

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix the use of default OpenSSL ciphers #3107

wants to merge 3 commits into from

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Aug 9, 2023

Closes #3100

sigmavirus24
sigmavirus24 approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@sigmavirus24 sigmavirus24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for debugging this @pquentin

sethmlarson
sethmlarson approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pquentin and @illia-v!

@pquentin
Copy link
Member Author

Thanks for the reviews. So the reason I have not merged yet is that I first thought that DEFAULT would be the system default, to allow users to control the ciphers, but I have not managed to do that on Fedora or Ubuntu. So this still needs some investigation.

@sshishov
Copy link

Am I missing something here? This MR is almost completely the same as #3060
And where @pquentin rejected the change. Did we discover something new? Like defaults from Cython?

@sethmlarson
Copy link
Member

@sshishov My understanding is "DEFAULT" is different than the system configured default, which is what we want. However, CPython has started setting a default which means that we're unable to revert to the true system default.

@elminson
Copy link

elminson commented Oct 16, 2023 •
edited

Am I missing something here? This MR is almost completely the same as #3060 And where @pquentin rejected the change. Did we discover something new? Like defaults from Cython?

🤷‍♂️ @sshishov had same question :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigmavirus24 sigmavirus24 sigmavirus24 approved these changes

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Behavior change: v2.x raises SSLEOFError with Python3.10 where v2.x does not with Python3.8
5 participants
@pquentin @sshishov @sethmlarson @elminson @sigmavirus24