Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit a warning when proxy_is_verified is False #2791

Open
sethmlarson opened this issue Nov 10, 2022 · 1 comment · May be fixed by #3070
Open

Emit a warning when proxy_is_verified is False #2791

sethmlarson opened this issue Nov 10, 2022 · 1 comment · May be fixed by #3070

Comments

@sethmlarson
Copy link
Member

Currently we have InsecureRequestWarning which is emitted when an HTTPSConnection isn't verified (for example, when verification is disabled). Now that we have HTTPConnection.proxy_is_verified we can detect when the proxy.scheme is https but the proxy connection isn't verified.

Perhaps the warning should be something like InsecureProxyWarning?
@tushar5526
Copy link
Contributor

Hey, I was taking a look at this and found that when proxy_scheme is HTTPS and the proxy is not verified, we get an InsecureRequestWarning instead of an InsecureProxyWarning. We can throw a warning when an insecure proxy is being used here - https://github.com/urllib3/urllib3/blob/main/src/urllib3/connectionpool.py#L1084 by adding appropriate checks.

@tushar5526 tushar5526 linked a pull request Jun 13, 2023 that will close this issue
Open
@nhpackard nhpackard mentioned this issue Apr 17, 2024
Closed
@paolovic paolovic mentioned this issue Apr 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Emit insecure proxy event when using unverified proxies tushar5526/urllib3
2 participants
@sethmlarson @tushar5526