Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate NTLMConnectionPool in 1.26.x #2282

Closed
sethmlarson opened this issue Jun 20, 2021 · 4 comments
Closed

Deprecate NTLMConnectionPool in 1.26.x #2282

sethmlarson opened this issue Jun 20, 2021 · 4 comments

Comments

@sethmlarson
Copy link
Member

As was mentioned in #2278 (comment) and #2278 (comment) we're moving to remove NTLMConnectionPool and the urllib3.contrib.nltmpool module from urllib3 in v2.0 if we don't find a new maintainer for the module (perhaps as a third-party package ie urllib3-ntlmpool?)

  • The module is not covered by our test suite.
  • It is not clear even which pypi package is needed for it.
  • It has fallen into disrepair (e.g. timeout/ssl/other options not being respected).
  • According to Wikipedia, "Since 2010, Microsoft no longer recommends NTLM in applications"
  • Seems like it's not used often, if at all.

In the 1.26.x branch we should unconditionally raise a DeprecationWarning when the module is imported. Should link to this issue with a call to action to comment in the issue if they are a user. This should help us better discover who (if any) our users are here so we can better make a decision.

@imkaka
Copy link
Contributor

imkaka commented Jun 21, 2021

I will try to work on this.

@sethmlarson
Copy link
Member Author

Sounds good @imkaka, let me know if you have questions.

@sethmlarson
Copy link
Member Author

Closed via #2289

kodiakhq bot pushed a commit to tprasadtp/protonvpn-docker that referenced this issue Jun 25, 2021
Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.5 to 1.26.6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/urllib3/urllib3/releases">urllib3's releases</a>.</em></p>
<blockquote>
<h2>1.26.6</h2>
<p>:warning: <strong>IMPORTANT: urllib3 v2.0 will drop support for Python 2</strong>: <a href="https://urllib3.readthedocs.io/en/latest/v2-roadmap.html">Read more in the v2.0 Roadmap</a></p>
<ul>
<li>Deprecated the <code>urllib3.contrib.ntlmpool</code> module. urllib3 is not able to support it properly due to <a href="https://github-redirect.dependabot.com/urllib3/urllib3/issues/2282">reasons listed in this issue</a>. If you are a user of this module please leave a comment.</li>
<li>Changed <code>HTTPConnection.request_chunked()</code> to not erroneously emit multiple <code>Transfer-Encoding</code> headers in the case that one is already specified.</li>
<li>Fixed typo in deprecation message to recommend <code>Retry.DEFAULT_ALLOWED_METHODS</code>.</li>
</ul>
<p><strong>If you or your organization rely on urllib3 consider supporting us via <a href="https://github.com/sponsors/urllib3">GitHub Sponsors</a></strong></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/urllib3/urllib3/blob/1.26.6/CHANGES.rst">urllib3's changelog</a>.</em></p>
<blockquote>
<h2>1.26.6 (2021-06-25)</h2>
<ul>
<li>Deprecated the <code>urllib3.contrib.ntlmpool</code> module. urllib3 is not able to support
it properly due to <code>reasons listed in this issue &lt;https://github.com/urllib3/urllib3/issues/2282&gt;</code>_.
If you are a user of this module please leave a comment.</li>
<li>Changed <code>HTTPConnection.request_chunked()</code> to not erroneously emit multiple
<code>Transfer-Encoding</code> headers in the case that one is already specified.</li>
<li>Fixed typo in deprecation message to recommend <code>Retry.DEFAULT_ALLOWED_METHODS</code>.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/urllib3/urllib3/commit/ba95e9eac73452d3bccfb5413b00d9a4fe3e4c31"><code>ba95e9e</code></a> Release 1.26.6</li>
<li><a href="https://github.com/urllib3/urllib3/commit/6930dde0167dfe038a9e6b331e2c850a7ec90d23"><code>6930dde</code></a> [1.26] Run integration tests in GitHub Actions</li>
<li><a href="https://github.com/urllib3/urllib3/commit/79d9249b9ddb6a251ef54bf36fd9fcfce5f4b946"><code>79d9249</code></a> [1.26] Fix typo 'tox' -&gt; 'nox' in contributing docs</li>
<li><a href="https://github.com/urllib3/urllib3/commit/95189954a98d29acd3a29764d14ae57f7473a2d0"><code>9518995</code></a> Update readthedocs URLs in 1.26.x branch to point to 1.26.x docs</li>
<li><a href="https://github.com/urllib3/urllib3/commit/eb28aec79de922100b246f2ac1cd4625394ff70c"><code>eb28aec</code></a> Don't emit multiple Transfer-Encoding headers in request_chunked()</li>
<li><a href="https://github.com/urllib3/urllib3/commit/2eead3e336dc200e4160e3fb6c0f85232a4196c9"><code>2eead3e</code></a> Deprecate the urllib3.contrib.ntlmpool module</li>
<li><a href="https://github.com/urllib3/urllib3/commit/033f194b2813c839c55d8dedcbce39007f6c7785"><code>033f194</code></a> [1.26.x] Remove CONTRIBUTORS.txt</li>
<li><a href="https://github.com/urllib3/urllib3/commit/ad90640073d4420aad09edf397d8f17a338295cd"><code>ad90640</code></a> [1.26.x] Add alternate 'dark mode' banner to documentation</li>
<li><a href="https://github.com/urllib3/urllib3/commit/782f05a7c312b5289f526f15e54a17c3cd77063d"><code>782f05a</code></a> Advertise Python 3.10 support in setup.py classifiers</li>
<li><a href="https://github.com/urllib3/urllib3/commit/a6b64c9048a431fe23a348cf08e3589f573632a5"><code>a6b64c9</code></a> Fix deprecation message to recommend Retry.DEFAULT_ALLOWED_METHODS</li>
<li>Additional commits viewable in <a href="https://github.com/urllib3/urllib3/compare/1.26.5...1.26.6">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=urllib3&package-manager=pip&previous-version=1.26.5&new-version=1.26.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Jun 29, 2021
1.26.6 (2021-06-25)
-------------------
* Deprecated the ``urllib3.contrib.ntlmpool`` module. urllib3 is not able to support
  it properly due to `reasons listed in this issue <https://github.com/urllib3/urllib3/issues/2282>`_.
  If you are a user of this module please leave a comment.
* Changed ``HTTPConnection.request_chunked()`` to not erroneously emit multiple
  ``Transfer-Encoding`` headers in the case that one is already specified.
* Fixed typo in deprecation message to recommend ``Retry.DEFAULT_ALLOWED_METHODS``.
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Jul 1, 2021
1.26.6 (2021-06-25)
-------------------

* Deprecated the ``urllib3.contrib.ntlmpool`` module. urllib3 is not able to support
  it properly due to `reasons listed in this issue <https://github.com/urllib3/urllib3/issues/2282>`_.
  If you are a user of this module please leave a comment.
* Changed ``HTTPConnection.request_chunked()`` to not erroneously emit multiple
  ``Transfer-Encoding`` headers in the case that one is already specified.
* Fixed typo in deprecation message to recommend ``Retry.DEFAULT_ALLOWED_METHODS``.

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Jul 1, 2021
1.26.6 (2021-06-25)
-------------------

* Deprecated the ``urllib3.contrib.ntlmpool`` module. urllib3 is not able to support
  it properly due to `reasons listed in this issue <https://github.com/urllib3/urllib3/issues/2282>`_.
  If you are a user of this module please leave a comment.
* Changed ``HTTPConnection.request_chunked()`` to not erroneously emit multiple
  ``Transfer-Encoding`` headers in the case that one is already specified.
* Fixed typo in deprecation message to recommend ``Retry.DEFAULT_ALLOWED_METHODS``.

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Jul 2, 2021
1.26.6 (2021-06-25)
-------------------

* Deprecated the ``urllib3.contrib.ntlmpool`` module. urllib3 is not able to support
  it properly due to `reasons listed in this issue <https://github.com/urllib3/urllib3/issues/2282>`_.
  If you are a user of this module please leave a comment.
* Changed ``HTTPConnection.request_chunked()`` to not erroneously emit multiple
  ``Transfer-Encoding`` headers in the case that one is already specified.
* Fixed typo in deprecation message to recommend ``Retry.DEFAULT_ALLOWED_METHODS``.

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Jul 2, 2021
1.26.6 (2021-06-25)
-------------------

* Deprecated the ``urllib3.contrib.ntlmpool`` module. urllib3 is not able to support
  it properly due to `reasons listed in this issue <https://github.com/urllib3/urllib3/issues/2282>`_.
  If you are a user of this module please leave a comment.
* Changed ``HTTPConnection.request_chunked()`` to not erroneously emit multiple
  ``Transfer-Encoding`` headers in the case that one is already specified.
* Fixed typo in deprecation message to recommend ``Retry.DEFAULT_ALLOWED_METHODS``.

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Jul 2, 2021
1.26.6 (2021-06-25)
-------------------

* Deprecated the ``urllib3.contrib.ntlmpool`` module. urllib3 is not able to support
  it properly due to `reasons listed in this issue <https://github.com/urllib3/urllib3/issues/2282>`_.
  If you are a user of this module please leave a comment.
* Changed ``HTTPConnection.request_chunked()`` to not erroneously emit multiple
  ``Transfer-Encoding`` headers in the case that one is already specified.
* Fixed typo in deprecation message to recommend ``Retry.DEFAULT_ALLOWED_METHODS``.

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Jul 3, 2021
1.26.6 (2021-06-25)
-------------------

* Deprecated the ``urllib3.contrib.ntlmpool`` module. urllib3 is not able to support
  it properly due to `reasons listed in this issue <https://github.com/urllib3/urllib3/issues/2282>`_.
  If you are a user of this module please leave a comment.
* Changed ``HTTPConnection.request_chunked()`` to not erroneously emit multiple
  ``Transfer-Encoding`` headers in the case that one is already specified.
* Fixed typo in deprecation message to recommend ``Retry.DEFAULT_ALLOWED_METHODS``.

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Jul 4, 2021
1.26.6 (2021-06-25)
-------------------

* Deprecated the ``urllib3.contrib.ntlmpool`` module. urllib3 is not able to support
  it properly due to `reasons listed in this issue <https://github.com/urllib3/urllib3/issues/2282>`_.
  If you are a user of this module please leave a comment.
* Changed ``HTTPConnection.request_chunked()`` to not erroneously emit multiple
  ``Transfer-Encoding`` headers in the case that one is already specified.
* Fixed typo in deprecation message to recommend ``Retry.DEFAULT_ALLOWED_METHODS``.

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Jul 4, 2021
1.26.6 (2021-06-25)
-------------------

* Deprecated the ``urllib3.contrib.ntlmpool`` module. urllib3 is not able to support
  it properly due to `reasons listed in this issue <https://github.com/urllib3/urllib3/issues/2282>`_.
  If you are a user of this module please leave a comment.
* Changed ``HTTPConnection.request_chunked()`` to not erroneously emit multiple
  ``Transfer-Encoding`` headers in the case that one is already specified.
* Fixed typo in deprecation message to recommend ``Retry.DEFAULT_ALLOWED_METHODS``.

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Jul 5, 2021
1.26.6 (2021-06-25)
-------------------

* Deprecated the ``urllib3.contrib.ntlmpool`` module. urllib3 is not able to support
  it properly due to `reasons listed in this issue <https://github.com/urllib3/urllib3/issues/2282>`_.
  If you are a user of this module please leave a comment.
* Changed ``HTTPConnection.request_chunked()`` to not erroneously emit multiple
  ``Transfer-Encoding`` headers in the case that one is already specified.
* Fixed typo in deprecation message to recommend ``Retry.DEFAULT_ALLOWED_METHODS``.

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Jul 5, 2021
1.26.6 (2021-06-25)
-------------------

* Deprecated the ``urllib3.contrib.ntlmpool`` module. urllib3 is not able to support
  it properly due to `reasons listed in this issue <https://github.com/urllib3/urllib3/issues/2282>`_.
  If you are a user of this module please leave a comment.
* Changed ``HTTPConnection.request_chunked()`` to not erroneously emit multiple
  ``Transfer-Encoding`` headers in the case that one is already specified.
* Fixed typo in deprecation message to recommend ``Retry.DEFAULT_ALLOWED_METHODS``.

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
halstead pushed a commit to openembedded/meta-openembedded that referenced this issue Jul 6, 2021
1.26.6 (2021-06-25)
-------------------

* Deprecated the ``urllib3.contrib.ntlmpool`` module. urllib3 is not able to support
  it properly due to `reasons listed in this issue <https://github.com/urllib3/urllib3/issues/2282>`_.
  If you are a user of this module please leave a comment.
* Changed ``HTTPConnection.request_chunked()`` to not erroneously emit multiple
  ``Transfer-Encoding`` headers in the case that one is already specified.
* Fixed typo in deprecation message to recommend ``Retry.DEFAULT_ALLOWED_METHODS``.

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
bluetech added a commit to bluetech/urllib3 that referenced this issue Jul 25, 2021
The module is likely broken and unlikely to be in use.

The module has been deprecated in urllib3 1.26.6 release and an advance
warning was given in its changelog.

Refs urllib3#2282.
@notatallshaw
Copy link

FYI I do work use Python with sites that use ntlm authentication. But historically I've used, and the only library other ntlm users have recommended, https://github.com/requests/requests-ntlm which is also no longer maintained and stopped working from urlib3 1.25.4 onwards anyway.

So as someone who still occasionally uses ntlm for legacy sites I wasn't even aware urllib3 had a corresponding module.

mtremer pushed a commit to ipfire/ipfire-2.x that referenced this issue Feb 14, 2022
- Update from 1.26.2 to 1.27.7
- Update of rootfile
- Changelog
1.26.7 (2021-09-22)
* Fixed a bug with HTTPS hostname verification involving IP addresses and lack
  of SNI. (Issue #2400)
* Fixed a bug where IPv6 braces weren't stripped during certificate hostname
  matching. (Issue #2240)
1.26.6 (2021-06-25)
* Deprecated the ``urllib3.contrib.ntlmpool`` module. urllib3 is not able to support
  it properly due to `reasons listed in this issue <https://github.com/urllib3/urllib3/issues/2282>`_.
  If you are a user of this module please leave a comment.
* Changed ``HTTPConnection.request_chunked()`` to not erroneously emit multiple
  ``Transfer-Encoding`` headers in the case that one is already specified.
* Fixed typo in deprecation message to recommend ``Retry.DEFAULT_ALLOWED_METHODS``.
1.26.5 (2021-05-26)
* Fixed deprecation warnings emitted in Python 3.10.
* Updated vendored ``six`` library to 1.16.0.
* Improved performance of URL parser when splitting
  the authority component.
1.26.4 (2021-03-15)
* Changed behavior of the default ``SSLContext`` when connecting to HTTPS proxy
  during HTTPS requests. The default ``SSLContext`` now sets ``check_hostname=True``.
1.26.3 (2021-01-26)
* Fixed bytes and string comparison issue with headers (Pull #2141)
* Changed ``ProxySchemeUnknown`` error message to be
  more actionable if the user supplies a proxy URL without
  a scheme. (Pull #2107)

Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
Reviewed-by: Peter Müller <peter.mueller@ipfire.org>
bors bot added a commit to meilisearch/meilisearch-gcp that referenced this issue Jun 4, 2022
68: Bump urllib3 from 1.26.3 to 1.26.9 r=alallema a=dependabot[bot]

Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.3 to 1.26.9.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/urllib3/urllib3/releases">urllib3's releases</a>.</em></p>
<blockquote>
<h2>1.26.9</h2>
<p><strong>If you or your organization rely on urllib3 consider supporting us via <a href="https://github.com/sponsors/urllib3">GitHub Sponsors</a>.</strong></p>
<p>:warning: <strong>urllib3 v2.0 will drop support for Python 2</strong>: <a href="https://urllib3.readthedocs.io/en/latest/v2-roadmap.html">Read more in the v2.0 Roadmap</a></p>
<p>:warning: <strong>This release will be the last release supporting Python 3.5. Please upgrade to a non-EOL Python version.</strong></p>
<ul>
<li>Changed <code>urllib3[brotli]</code> extra to favor installing Brotli libraries that are still receiving updates like <code>brotli</code> and <code>brotlicffi</code> instead of <code>brotlipy</code>. This change does not impact behavior of urllib3, only which dependencies are installed.</li>
<li>Fixed a socket leaking when <code>HTTPSConnection.connect()</code> raises an exception.</li>
<li>Fixed <code>server_hostname</code> being forwarded from <code>PoolManager</code> to <code>HTTPConnectionPool</code>
when requesting an HTTP URL. Should only be forwarded when requesting an HTTPS URL.</li>
</ul>
<h2>1.26.8</h2>
<p><strong>If you or your organization rely on urllib3 consider supporting us via <a href="https://github.com/sponsors/urllib3">GitHub Sponsors</a>.</strong></p>
<p>:warning: <strong>urllib3 v2.0 will drop support for Python 2</strong>: <a href="https://urllib3.readthedocs.io/en/latest/v2-roadmap.html">Read more in the v2.0 Roadmap</a></p>
<p>:warning: <strong>This release will be the last release supporting Python 3.5. Please upgrade to a non-EOL Python version.</strong></p>
<ul>
<li>Added extra message to<code>urllib3.exceptions.ProxyError</code> when urllib3 detects that a proxy is configured to use HTTPS but the proxy itself appears to only use HTTP.</li>
<li>Added a mention of the size of the connection pool when discarding a connection due to the pool being full.</li>
<li>Added explicit support for Python 3.11.</li>
<li>Deprecated the <code>Retry.MAX_BACKOFF</code> class property in favor of <code>Retry.DEFAULT_MAX_BACKOFF</code> to better match the rest of the default parameter names. <code>Retry.MAX_BACKOFF</code> is removed in v2.0.</li>
<li>Changed location of the vendored <code>ssl.match_hostname</code> function from <code>urllib3.packages.ssl_match_hostname</code> to <code>urllib3.util.ssl_match_hostname</code> to ensure Python 3.10+ compatibility after being repackaged by downstream distributors.</li>
<li>Fixed absolute imports, all imports are now relative.</li>
</ul>
<h2>1.26.7</h2>
<p>:warning: <strong>IMPORTANT: urllib3 v2.0 will drop support for Python 2</strong>: <a href="https://urllib3.readthedocs.io/en/latest/v2-roadmap.html">Read more in the v2.0 Roadmap</a></p>
<ul>
<li>Fixed a bug with HTTPS hostname verification involving IP addresses and lack of SNI</li>
<li>Fixed a bug where IPv6 braces weren't stripped during certificate hostname matching</li>
</ul>
<p><strong>If you or your organization rely on urllib3 consider supporting us via <a href="https://github.com/sponsors/urllib3">GitHub Sponsors</a></strong></p>
<h2>1.26.6</h2>
<p>:warning: <strong>IMPORTANT: urllib3 v2.0 will drop support for Python 2</strong>: <a href="https://urllib3.readthedocs.io/en/latest/v2-roadmap.html">Read more in the v2.0 Roadmap</a></p>
<ul>
<li>Deprecated the <code>urllib3.contrib.ntlmpool</code> module. urllib3 is not able to support it properly due to <a href="https://github-redirect.dependabot.com/urllib3/urllib3/issues/2282">reasons listed in this issue</a>. If you are a user of this module please leave a comment.</li>
<li>Changed <code>HTTPConnection.request_chunked()</code> to not erroneously emit multiple <code>Transfer-Encoding</code> headers in the case that one is already specified.</li>
<li>Fixed typo in deprecation message to recommend <code>Retry.DEFAULT_ALLOWED_METHODS</code>.</li>
</ul>
<p><strong>If you or your organization rely on urllib3 consider supporting us via <a href="https://github.com/sponsors/urllib3">GitHub Sponsors</a></strong></p>
<h2>1.26.5</h2>
<p>:warning: <strong>IMPORTANT: urllib3 v2.0 will drop support for Python 2</strong>: <a href="https://urllib3.readthedocs.io/en/latest/v2-roadmap.html">Read more in the v2.0 Roadmap</a></p>
<ul>
<li>Fixed deprecation warnings emitted in Python 3.10.</li>
<li>Updated vendored <code>six</code> library to 1.16.0.</li>
<li>Improved performance of URL parser when splitting the authority component.</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/urllib3/urllib3/blob/1.26.9/CHANGES.rst">urllib3's changelog</a>.</em></p>
<blockquote>
<h2>1.26.9 (2022-03-16)</h2>
<ul>
<li>Changed <code>urllib3[brotli]</code> extra to favor installing Brotli libraries that are still
receiving updates like <code>brotli</code> and <code>brotlicffi</code> instead of <code>brotlipy</code>.
This change does not impact behavior of urllib3, only which dependencies are installed.</li>
<li>Fixed a socket leaking when <code>HTTPSConnection.connect()</code> raises an exception.</li>
<li>Fixed <code>server_hostname</code> being forwarded from <code>PoolManager</code> to <code>HTTPConnectionPool</code>
when requesting an HTTP URL. Should only be forwarded when requesting an HTTPS URL.</li>
</ul>
<h2>1.26.8 (2022-01-07)</h2>
<ul>
<li>Added extra message to <code>urllib3.exceptions.ProxyError</code> when urllib3 detects that
a proxy is configured to use HTTPS but the proxy itself appears to only use HTTP.</li>
<li>Added a mention of the size of the connection pool when discarding a connection due to the pool being full.</li>
<li>Added explicit support for Python 3.11.</li>
<li>Deprecated the <code>Retry.MAX_BACKOFF</code> class property in favor of <code>Retry.DEFAULT_MAX_BACKOFF</code>
to better match the rest of the default parameter names. <code>Retry.MAX_BACKOFF</code> is removed in v2.0.</li>
<li>Changed location of the vendored <code>ssl.match_hostname</code> function from <code>urllib3.packages.ssl_match_hostname</code>
to <code>urllib3.util.ssl_match_hostname</code> to ensure Python 3.10+ compatibility after being repackaged
by downstream distributors.</li>
<li>Fixed absolute imports, all imports are now relative.</li>
</ul>
<h2>1.26.7 (2021-09-22)</h2>
<ul>
<li>Fixed a bug with HTTPS hostname verification involving IP addresses and lack
of SNI. (Issue <a href="https://github-redirect.dependabot.com/urllib3/urllib3/issues/2400">#2400</a>)</li>
<li>Fixed a bug where IPv6 braces weren't stripped during certificate hostname
matching. (Issue <a href="https://github-redirect.dependabot.com/urllib3/urllib3/issues/2240">#2240</a>)</li>
</ul>
<h2>1.26.6 (2021-06-25)</h2>
<ul>
<li>Deprecated the <code>urllib3.contrib.ntlmpool</code> module. urllib3 is not able to support
it properly due to <code>reasons listed in this issue &lt;https://github.com/urllib3/urllib3/issues/2282&gt;</code>_.
If you are a user of this module please leave a comment.</li>
<li>Changed <code>HTTPConnection.request_chunked()</code> to not erroneously emit multiple
<code>Transfer-Encoding</code> headers in the case that one is already specified.</li>
<li>Fixed typo in deprecation message to recommend <code>Retry.DEFAULT_ALLOWED_METHODS</code>.</li>
</ul>
<h2>1.26.5 (2021-05-26)</h2>
<ul>
<li>Fixed deprecation warnings emitted in Python 3.10.</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/urllib3/urllib3/commit/6de3330eb54f73a57c7860f75123bde8b043dbd2"><code>6de3330</code></a> Release 1.26.9</li>
<li><a href="https://github.com/urllib3/urllib3/commit/5ea33e159ef9f11282240da5f6af1e3a5563b334"><code>5ea33e1</code></a> [1.26] Switch to Brotli C bindings for CPython, brotlicffi for non-CPython</li>
<li><a href="https://github.com/urllib3/urllib3/commit/c0a182c6300a34cba58b5e80749584d7b621c7dd"><code>c0a182c</code></a> [1.26] Avoid socket leak if HTTPSConnection.connect() fails</li>
<li><a href="https://github.com/urllib3/urllib3/commit/5cf6d03a85b28c76a5a05ccddebdeda064f0936f"><code>5cf6d03</code></a> [1.26] Fix formatting in changelog</li>
<li><a href="https://github.com/urllib3/urllib3/commit/834dd1edba7b020cb20462862c114bb3def30a0b"><code>834dd1e</code></a> [1.26] Complete test coverage of urllib3.util.ssl_match_hostname.match_hostname</li>
<li><a href="https://github.com/urllib3/urllib3/commit/048c0ba15cec8c7dd787670bcafd243a54590982"><code>048c0ba</code></a> [1.26] Combine UnicodeError and ValueError branches in ssl_match_hostname for...</li>
<li><a href="https://github.com/urllib3/urllib3/commit/a4539fb48c9d827739a77a6323093434bd11ba63"><code>a4539fb</code></a> [1.26] Add test to complete the coverage of urllib3.util.ssl_match_hostname.m...</li>
<li><a href="https://github.com/urllib3/urllib3/commit/d662fcd9301b94a413a0d21c6c287268cd082da1"><code>d662fcd</code></a> [1.26] Stop advertising python setup.py install</li>
<li><a href="https://github.com/urllib3/urllib3/commit/778e585d9b5c86de22c9fb736ed7a80982622334"><code>778e585</code></a> [1.26] Show missing lines in coverage report</li>
<li><a href="https://github.com/urllib3/urllib3/commit/f1d40fd07f7b5d9cf846a18fb5a920b4be07dfc5"><code>f1d40fd</code></a> [1.26] Add server_hostname to SSL_KEYWORDS</li>
<li>Additional commits viewable in <a href="https://github.com/urllib3/urllib3/compare/1.26.3...1.26.9">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=urllib3&package-manager=pip&previous-version=1.26.3&new-version=1.26.9)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

You can trigger a rebase of this PR by commenting ``@dependabot` rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
daregit pushed a commit to daregit/yocto-combined that referenced this issue May 22, 2024
1.26.6 (2021-06-25)
-------------------

* Deprecated the ``urllib3.contrib.ntlmpool`` module. urllib3 is not able to support
  it properly due to `reasons listed in this issue <https://github.com/urllib3/urllib3/issues/2282>`_.
  If you are a user of this module please leave a comment.
* Changed ``HTTPConnection.request_chunked()`` to not erroneously emit multiple
  ``Transfer-Encoding`` headers in the case that one is already specified.
* Fixed typo in deprecation message to recommend ``Retry.DEFAULT_ALLOWED_METHODS``.

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
daregit pushed a commit to daregit/yocto-combined that referenced this issue May 22, 2024
1.26.6 (2021-06-25)
-------------------

* Deprecated the ``urllib3.contrib.ntlmpool`` module. urllib3 is not able to support
  it properly due to `reasons listed in this issue <https://github.com/urllib3/urllib3/issues/2282>`_.
  If you are a user of this module please leave a comment.
* Changed ``HTTPConnection.request_chunked()`` to not erroneously emit multiple
  ``Transfer-Encoding`` headers in the case that one is already specified.
* Fixed typo in deprecation message to recommend ``Retry.DEFAULT_ALLOWED_METHODS``.

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants