Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message for ProxySchemeUnknown exception #2107

Merged
merged 1 commit into from Dec 11, 2020

Conversation

hramezani
Copy link
Member

Backport 2dcfde7

@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #2107 (1ae9b60) into 1.26.x (dd00949) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           1.26.x    #2107      +/-   ##
==========================================
+ Coverage   99.78%   99.91%   +0.13%     
==========================================
  Files          25       25              
  Lines        2299     2303       +4     
==========================================
+ Hits         2294     2301       +7     
+ Misses          5        2       -3     
Impacted Files Coverage Δ
src/urllib3/exceptions.py 100.00% <100.00%> (ø)
src/urllib3/response.py 100.00% <0.00%> (+0.54%) ⬆️
src/urllib3/contrib/_appengine_environ.py 100.00% <0.00%> (+10.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd00949...1ae9b60. Read the comment docs.

Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, CI failures are unrelated.

@sethmlarson sethmlarson merged commit 947284e into urllib3:1.26.x Dec 11, 2020
This was referenced Mar 12, 2021
This was referenced Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants