New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import features from ssl module with more granularity #2052
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2052 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 2296 2298 +2
=========================================
+ Hits 2296 2298 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appreciate the quick turnaround! |
Very subtle bug here that was caused by isort reordering the imports within
try-except
. Here's the diff ofurllib3.util.ssl_
between 1.25.11 and 1.26.1 that caused the bug:Notice how
HAS_SNI
is now being imported beforewrap_socket
andCERT_REQUIRED
andHAS_SNI
is a Python 2.7.9 feature. This meant that imports on Python 2.7.8 and earlier weren't gettingwrap_socket
imported in time beforeHAS_SNI
was causing anImportError
.Verified this locally with the
python:2.7.8
Docker container, we currently don't have CI for this Python version.Closes #2051