Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set keylog_filename for empty values #2016

Merged
merged 1 commit into from Oct 4, 2020

Conversation

sethmlarson
Copy link
Member

Closes #2015

@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #2016 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2016   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines         2290      2292    +2     
=========================================
+ Hits          2290      2292    +2     
Impacted Files Coverage Δ
src/urllib3/util/ssl_.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1f05ae...61737c2. Read the comment docs.

@sethmlarson sethmlarson merged commit 4fb7f32 into urllib3:master Oct 4, 2020
@sethmlarson sethmlarson deleted the empty-sslkeylogfile branch October 9, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keylog_filename triggering error when SSLKEYLOGFILE is not set
2 participants