New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate negotiating TLSv1 and TLSv1.1 by default #2002
Conversation
The approach looks good, thanks! This breaks other tests, though, we'd have to fix that first |
@pquentin Yeah I couldn't run the TLS<1.2 tests on my local machine because Ubuntu disables it via OpenSSL config now (:tada:) and upon seeing how many failures there were threw my hands up and said "another time!" :) |
Codecov Report
@@ Coverage Diff @@
## master #2002 +/- ##
=========================================
Coverage ? 99.86%
=========================================
Files ? 25
Lines ? 2294
Branches ? 0
=========================================
Hits ? 2291
Misses ? 3
Partials ? 0
Continue to review full report at Codecov.
|
@pquentin Ready for a review now that tests are passing. The macOS 3.8 failure is strange, I'm not seeing any logs? |
If you click on "View raw logs", you can see that the failure is The new warning makes running the TLS 1.0 and 1.1 tests quite noisy, is there a way to not display them in pytest? |
Hmm that's true, we can potentially set |
Yeah, if that sounds good to me if it's easy to do. (Sorry, haven't read the actual diff for now, I'm fighting with CI instead!) Closing/reopening to rerun due to another socketlevel flaky test. (Tests are way more flaky when the US workday starts!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good, though I'd like to see what can be done to reduce the warnings shown when running tests.
@pquentin Yeah we might have to live with the noisiness for now, any other work-around is pretty painful. We'll get away from it after v2 though! |
Closes #1990