Wrap BaseSSLError into SSLError during response reads #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquentin
previously approved these changes
Aug 29, 2020
|
I'll create a small test case :) |
sethmlarson
force-pushed
the
wrap-sslerror-error-catcher
branch
2 times, most recently
from
dda3f13
to
7c27e0d
Compare
sethmlarson
force-pushed
the
wrap-sslerror-error-catcher
branch
from
7c27e0d
to
fcb90ef
Compare
pquentin
reviewed
Aug 31, 2020
| @@ -443,9 +444,8 @@ def _error_catcher(self): | |||
| except BaseSSLError as e: | |||
| # FIXME: Is there a better way to differentiate between SSLErrors? | |||
| if "read operation timed out" not in str(e): # Defensive: | |||
There was a problem hiding this comment.
Can we remove that Defensive pragma? Without that, I think we won't get coverage information for that condition.
There was a problem hiding this comment.
Oh yeah, I'll remove that :) Nice catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1764