Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assume UTC timezone if none specified in Retry-After header #1935

Merged
merged 5 commits into from Aug 26, 2020
Merged

Assume UTC timezone if none specified in Retry-After header #1935

merged 5 commits into from Aug 26, 2020

Conversation

hodbn
Copy link
Member

@hodbn hodbn commented Aug 25, 2020 •
edited

Closes #1934.

@hodbn hodbn requested a review from sethmlarson August 25, 2020 19:40
sethmlarson
sethmlarson requested changes Aug 25, 2020
View reviewed changes
Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, how'd you find this failure? I didn't see any failed tests on CI.

src/urllib3/util/retry.py Show resolved Hide resolved
@sethmlarson
Copy link
Member

An additional comment now that I know how the failure was found: Can we add a test case that fails without this patch?

sethmlarson
sethmlarson requested changes Aug 26, 2020
View reviewed changes
Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments! ✨

test/tz_fake.py Outdated Show resolved Hide resolved
test/tz_fake.py Outdated Show resolved Hide resolved
dev-requirements.txt Outdated Show resolved Hide resolved
test/tz_fake.py Outdated Show resolved Hide resolved
@hodbn hodbn requested a review from sethmlarson August 26, 2020 18:46
sethmlarson
sethmlarson approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sethmlarson sethmlarson merged commit cf6ab7a into urllib3:master Aug 26, 2020
@sethmlarson sethmlarson mentioned this pull request Oct 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect handling of Retry-After (2.7)
2 participants
@hodbn @sethmlarson