Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tz-aware functions in Retry.parse_retry_after() #1932

Merged
merged 1 commit into from Aug 24, 2020
Merged

Use tz-aware functions in Retry.parse_retry_after() #1932

merged 1 commit into from Aug 24, 2020

Conversation

sethmlarson
Copy link
Member

Switches parsedate and mktime to the tz-aware equivalents in email.utils. Also adds Freezegun as a dev dependency for complete time-mocking.

Closes #1896

pquentin
pquentin previously approved these changes Aug 23, 2020
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I like the symmetry between parsedate_tz and mktime_tz. :) And freezegun is a great find.

@sethmlarson
Copy link
Member Author

Pinned to 0.3.0.post1 because apparently there's no Python 2-compatible dist for that version. Now CI should work, going to merge after the install on Python 2 works.

@sethmlarson sethmlarson merged commit 0210ddb into urllib3:master Aug 24, 2020
@sethmlarson sethmlarson deleted the retry-after-tz branch August 24, 2020 00:13
@pquentin
Copy link
Member

(For what it's worth: my intent was to click on approve, not comment)

@sethmlarson sethmlarson mentioned this pull request Oct 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sethmlarson @pquentin