Collapse request chunked data and framing into one send() call #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1906 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 2049 2109 +60
=========================================
+ Hits 2049 2109 +60
Continue to review full report at Codecov.
|
sethmlarson
added a commit
to sethmlarson/urllib3
that referenced
this pull request
Jul 16, 2020
sethmlarson
added a commit
to sethmlarson/urllib3
that referenced
this pull request
Jul 19, 2020
sethmlarson
added a commit
to sethmlarson/urllib3
that referenced
this pull request
Jul 19, 2020
sethmlarson
added a commit
that referenced
this pull request
Jul 22, 2020
This was referenced Mar 12, 2021
This was referenced Mar 16, 2021
Dobatymo
pushed a commit
to Dobatymo/urllib3
that referenced
this pull request
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at how urllib3 behaves with Wireshark I saw chunks and chunk framing being sent in separate TCP packets even when only a few bytes. Collapsing data and framing into one
send()call alleviated this issue. Should reduce the number of TCP packets sent when usingrequest_chunkedby ~2-4x.I'd like to backport this to 1.25-series and potentially make a release there with other bug fixes that have landed.