Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unnecessary SNI warning with SecureTransport #1903

Merged
merged 3 commits into from Aug 24, 2020

Conversation

hodbn
Copy link
Member

@hodbn hodbn commented Jul 13, 2020

Closes #1902.

@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #1903 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #1903      +/-   ##
===========================================
+ Coverage   99.95%   100.00%   +0.04%     
===========================================
  Files          23        23              
  Lines        2049      2052       +3     
===========================================
+ Hits         2048      2052       +4     
+ Misses          1         0       -1     
Flag Coverage Δ
#unittests 99.56% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
src/urllib3/util/ssl_.py 100.00% <100.00%> (ø)
src/urllib3/util/wait.py 100.00% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5a45dc...90b53d5. Read the comment docs.

@sethmlarson
Copy link
Member

Will give this a review today :)

@pquentin
Copy link
Member

@sethmlarson Is there anything making reviewing this difficult?

Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for taking so long on the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary SNI warning with SecureTransport
3 participants