Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change TARPIT_HOST to detect isolated network #1862

Merged
merged 2 commits into from Apr 24, 2020
Merged

Change TARPIT_HOST to detect isolated network #1862

merged 2 commits into from Apr 24, 2020

Conversation

hodbn
Copy link
Member

@hodbn hodbn commented Apr 23, 2020

Closes #1756.

@codecov
Copy link

codecov bot commented Apr 23, 2020 •
edited

Codecov Report

Merging #1862 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1862   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines         2013      2013           
=========================================
  Hits          2013      2013
Flag Coverage Δ
#unittests 99.60% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b53aa...6cb6de4. Read the comment docs.

pquentin
pquentin previously approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have a little suggestion to reduce the line length.

test/__init__.py Outdated Show resolved Hide resolved
sethmlarson
sethmlarson previously approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after applying @pquentin's suggestion

@pquentin pquentin dismissed stale reviews from sethmlarson and themself via 6cb6de4 April 24, 2020 12:32
pquentin
pquentin approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since I only applied a suggestion that Seth just approved.

@pquentin pquentin changed the title Change TARPIT_HOST to better values Change TARPIT_HOST to detect isolated network Apr 24, 2020
@pquentin pquentin merged commit 898a16d into urllib3:master Apr 24, 2020
pquentin pushed a commit to robermorales/urllib3 that referenced this pull request Jun 30, 2020
@hodbn @pquentin
Change TARPIT_HOST to detect isolated network (urllib3#1862)
2a12bcf
sethmlarson pushed a commit to sethmlarson/urllib3 that referenced this pull request Jul 16, 2020
@hodbn @sethmlarson
[1.25] Change TARPIT_HOST to detect isolated network (urllib3#1862)
829380a
sethmlarson pushed a commit that referenced this pull request Jul 22, 2020
@hodbn @sethmlarson
[1.25] Change TARPIT_HOST to detect isolated network (#1862)
7a4a7a1
Dobatymo pushed a commit to Dobatymo/urllib3 that referenced this pull request Mar 16, 2022
@hodbn
Change TARPIT_HOST to detect isolated network (urllib3#1862)
33527ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

@sethmlarson sethmlarson sethmlarson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_https_timeout & test_enhanced_timeout fail when there's no networking
3 participants
@hodbn @pquentin @sethmlarson