New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add InvalidProxyConfigurationWarning for HTTPS proxies #1851
Add InvalidProxyConfigurationWarning for HTTPS proxies #1851
Conversation
Oh no, what have I done? |
@joelverhagen My apologies, I meant @jalopezsilva :) But I'm sure you're up to no good! ;) |
Codecov Report
@@ Coverage Diff @@
## 1.25-series #1851 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 22 22
Lines 1999 2004 +5
=============================================
+ Hits 1999 2004 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1850 says this:
As of v1.25.x urllib3 doesn't support HTTPS proxies and the proxy will be contacted via HTTP instead when connecting to an HTTPS URL.
When I read this, it seemed to me that the change was in 1.25.x. What do you think of a wording like this instead? (Not a native speaker, so it may not make sense, it's only a suggestion.)
urllib3 up to v1.25.x doesn't support HTTPS proxies. When connecting to an HTTPS URL, urllib3 contacts the proxy via HTTP instead.
I like your wording more @pquentin, was struggling to come up with something late last night. :) |
I pre-allocated #1850 for users that are receiving the issue. I have a feeling we may need to lock the conversation if it attracts too much traffic but it's better than leaving users without an official means of solving the issue.
cc @jalopezsilva