Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InvalidProxyConfigurationWarning for HTTPS proxies #1851

Merged
merged 2 commits into from Apr 16, 2020

Conversation

sethmlarson
Copy link
Member

@sethmlarson sethmlarson commented Apr 16, 2020

I pre-allocated #1850 for users that are receiving the issue. I have a feeling we may need to lock the conversation if it attracts too much traffic but it's better than leaving users without an official means of solving the issue.

cc @jalopezsilva

@joelverhagen
Copy link
Contributor

Oh no, what have I done?

@sethmlarson
Copy link
Member Author

@joelverhagen My apologies, I meant @jalopezsilva :) But I'm sure you're up to no good! ;)

@sethmlarson sethmlarson mentioned this pull request Apr 16, 2020
@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #1851 into 1.25-series will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           1.25-series     #1851   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files               22        22           
  Lines             1999      2004    +5     
=============================================
+ Hits              1999      2004    +5     
Flag Coverage Δ
#unittests 99.60% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
src/urllib3/exceptions.py 100.00% <100.00%> (ø)
src/urllib3/poolmanager.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ec3438...5edde98. Read the comment docs.

@sethmlarson sethmlarson mentioned this pull request Apr 16, 2020
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1850 says this:

As of v1.25.x urllib3 doesn't support HTTPS proxies and the proxy will be contacted via HTTP instead when connecting to an HTTPS URL.

When I read this, it seemed to me that the change was in 1.25.x. What do you think of a wording like this instead? (Not a native speaker, so it may not make sense, it's only a suggestion.)

urllib3 up to v1.25.x doesn't support HTTPS proxies. When connecting to an HTTPS URL, urllib3 contacts the proxy via HTTP instead.

src/urllib3/poolmanager.py Show resolved Hide resolved
@sethmlarson
Copy link
Member Author

I like your wording more @pquentin, was struggling to come up with something late last night. :)

@sethmlarson sethmlarson merged commit c930dc0 into urllib3:1.25-series Apr 16, 2020
@sethmlarson sethmlarson deleted the proxy-https-warning branch April 16, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants