New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix documentation build by skipping Sphinx 3.0.0 #1844
Conversation
Sphinx 3 currently fails with an mysterious ValueError: `wrapper loop when unwrapping <MockModule id='139897808864312'>`
Codecov Report
@@ Coverage Diff @@
## master #1844 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 2013 2013
=========================================
Hits 2013 2013
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently this is a known issue (https://bugs.python.org/issue25532#msg253887).
The suggested workaround works on my machine (python3.6), in docs/conf.py:
class MockModule(mock.Mock):
@classmethod
def __getattr__(cls, name):
# See https://bugs.python.org/issue25532#msg253887
if name == '__wrapped__':
raise AttributeError()
return MockModule()
Can you add it?
Give @hodbn's comment a try but if it doesn't work we can pin to 2.x. We don't gain a lot from 3.x from their changelog. |
The autodoc_mock_imports failure will be fixed in Sphinx 3.0.1.
This is a bug in Sphinx that will be fixed in 3.0.1 so I just skip 3.0.0 for now. |
I fixed the macOS flaky test in #1846, please consider merging this as is: the docs CI passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
The autodoc_mock_imports failure will be fixed in Sphinx 3.0.1.
The autodoc_mock_imports failure will be fixed in Sphinx 3.0.1.
Sphinx 3 currently fails with an mysterious ValueError:
wrapper loop when unwrapping <MockModule id='139897808864312'>