Detect GitHub Actions as continuous integration #1840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethmlarson
approved these changes
Apr 2, 2020
Codecov Report
@@ Coverage Diff @@
## master #1840 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 2007 2007
=========================================
Hits 2007 2007
Continue to review full report at Codecov.
|
sethmlarson
pushed a commit
to sethmlarson/urllib3
that referenced
this pull request
Apr 11, 2020
Dobatymo
pushed a commit
to Dobatymo/urllib3
that referenced
this pull request
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting up longer timeouts on continuous integration, I noticed that the "CI" environment variable was not available on GitHub Actions, and realized that it would be easy to forget when switching to GitHub Actions. And indeed, I forgot about it! And then https://github.com/urllib3/urllib3/runs/553809349 failed because
LONG_TIMEOUTwas too small. This pull request fixes that.(By the way, the macOS builds are currently really slow, 2x to 3x slower than on Travis, even if they start faster. But it's still worth it, thanks to the parallelism.)