Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch macOS CI to GitHub Actions #1839

Merged
merged 1 commit into from Apr 2, 2020

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Apr 1, 2020

The macOS tests are the current bottleneck, which is why I'm moving them first. I've simply copy-pasted my work from https://github.com/python-trio/hip/blob/master/.github/workflows/ci.yml. GitHub Actions is nice because it gives up to 20x parallelism and is better integrated with GitHub, however the UI is barely usable when the tests are still running. Good news: a codecov token is no longer required.

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #1839 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1839   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         2007      2007           
=========================================
  Hits          2007      2007           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9508d8...253fb38. Read the comment docs.

@pquentin
Copy link
Member Author

pquentin commented Apr 1, 2020

I guess I should have opened this one from a branch in the main repo, as GitHub Actions can't be activated on the first pull request.

You can see the tests running here: https://github.com/pquentin/urllib3/actions/runs/68378346

Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, great work here! Looking forward to being able to completely delete the _travis and appveyor folders. Once we get our first run I'll add the necessary "required" checks for the master branch to the repo.

@sethmlarson
Copy link
Member

Also I enabled Actions, they were previously disabled. Maybe that's why things didn't show up here?

@pquentin
Copy link
Member Author

pquentin commented Apr 2, 2020

Hm, did not work yet. Let's try merging this, we can always revert.

@pquentin pquentin merged commit c8f63f6 into urllib3:master Apr 2, 2020
@pquentin pquentin deleted the macos-github-actions branch April 2, 2020 02:37
@pquentin
Copy link
Member Author

pquentin commented Apr 2, 2020

It worked! https://github.com/urllib3/urllib3/actions/runs/68722383 We'll need to update our badges list. Not sure if Travis can go fully away as I don't know how to run PyPy or 3.9-dev in Actions.

sethmlarson pushed a commit to sethmlarson/urllib3 that referenced this pull request Apr 11, 2020
Dobatymo pushed a commit to Dobatymo/urllib3 that referenced this pull request Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants