Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix retry to account for errors inside a ProxyError #1830

Merged
merged 4 commits into from Apr 3, 2020
Merged

Fix retry to account for errors inside a ProxyError #1830

merged 4 commits into from Apr 3, 2020

Conversation

hodbn
Copy link
Member

@hodbn hodbn commented Mar 28, 2020

Closes #1744

@hodbn hodbn changed the title fix Retry to handle a ProxyError of NewConnectionError Fix retry to account for errors inside a ProxyError Mar 29, 2020
sethmlarson
sethmlarson requested changes Mar 29, 2020
View reviewed changes
Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, few comments for you.

src/urllib3/util/retry.py Show resolved Hide resolved
test/test_proxymanager.py Show resolved Hide resolved
@hodbn hodbn requested a review from sethmlarson March 29, 2020 23:04
@hodbn hodbn mentioned this pull request Mar 31, 2020
Merged
@hodbn
Copy link
Member Author

hodbn commented Apr 1, 2020

Updated to use new find_unused_port (#1837).

@hodbn hodbn requested a review from pquentin April 1, 2020 10:48
@hodbn hodbn closed this Apr 1, 2020
@hodbn hodbn reopened this Apr 1, 2020
@codecov
Copy link

codecov bot commented Apr 1, 2020 •
edited

Codecov Report

Merging #1830 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1830   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         2007      2012    +5     
=========================================
+ Hits          2007      2012    +5
Flag Coverage Δ
#unittests 99.60% <100.00%> (?)
Impacted Files Coverage Δ
src/urllib3/exceptions.py 100.00% <100.00%> (ø)
src/urllib3/util/retry.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9508d8...dad2376. Read the comment docs.

sethmlarson
sethmlarson requested changes Apr 2, 2020
View reviewed changes
Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there! Also need CI to pass.

test/test_proxymanager.py Show resolved Hide resolved
sethmlarson
sethmlarson approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethmlarson sethmlarson merged commit 84073f9 into urllib3:master Apr 3, 2020
sethmlarson pushed a commit to sethmlarson/urllib3 that referenced this pull request Apr 11, 2020
@hodbn @sethmlarson
Unwrap ProxyError when evaluating retries (urllib3#1830)
308a08f
Dobatymo pushed a commit to Dobatymo/urllib3 that referenced this pull request Mar 16, 2022
@hodbn
Unwrap ProxyError when evaluating retries (urllib3#1830)
14a3960
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

@pquentin pquentin Awaiting requested review from pquentin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PoolManager and ProxyManager process retries differently
2 participants
@hodbn @sethmlarson