Ensure load_verify_locations raises SSLError for all backends #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds TestSSL to the classes tested in SecureTransport and PyOpenSSL, since: 1. TestSSL was the most natural place for this test. 2. The test only makes sense when run against all SSL backends. Co-authored-by: Pierre-Louis Bonicoli <pierre-louis.bonicoli@libregerbil.fr>
|
@pilou- I can't assign you, but would love a review too! Thanks |
sethmlarson
requested changes
Mar 16, 2020
| """ | ||
| with pytest.raises(SSLError) as exc: | ||
| ssl_wrap_socket(None, ca_certs=os.devnull) | ||
| assert exc.type == SSLError |
There was a problem hiding this comment.
Isn't this assert redundant with the pytest.raises()?
There was a problem hiding this comment.
Nice catch, thanks! Fixed.
pytest.raises() already checks this.
|
Thanks @sethmlarson for the lint fix and the approval. Thank you @pilou- for your contribution! |
sethmlarson
added a commit
to sethmlarson/urllib3
that referenced
this pull request
Apr 11, 2020
…3#1812) * Ensure load_verify_locations raises SSLError for all backends This also adds TestSSL to the classes tested in SecureTransport and PyOpenSSL, since: 1. TestSSL was the most natural place for this test. 2. The test only makes sense when run against all SSL backends. Co-authored-by: Pierre-Louis Bonicoli <pierre-louis.bonicoli@libregerbil.fr> * Remove redundant check in test pytest.raises() already checks this. * Update test_socketlevel.py Co-authored-by: Pierre-Louis Bonicoli <pierre-louis.bonicoli@libregerbil.fr> Co-authored-by: Seth Michael Larson <sethmichaellarson@gmail.com>
Dobatymo
pushed a commit
to Dobatymo/urllib3
that referenced
this pull request
Mar 16, 2022
…3#1812) * Ensure load_verify_locations raises SSLError for all backends This also adds TestSSL to the classes tested in SecureTransport and PyOpenSSL, since: 1. TestSSL was the most natural place for this test. 2. The test only makes sense when run against all SSL backends. Co-authored-by: Pierre-Louis Bonicoli <pierre-louis.bonicoli@libregerbil.fr> * Remove redundant check in test pytest.raises() already checks this. * Update test_socketlevel.py Co-authored-by: Pierre-Louis Bonicoli <pierre-louis.bonicoli@libregerbil.fr> Co-authored-by: Seth Michael Larson <sethmichaellarson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds TestSSL to the classes tested in SecureTransport and PyOpenSSL, since:
This is my take on #1517 from @pilou-: I've backported it to master, and made a few tweaks. In particular, we can't test the exact message, it's different with every backend.
Closes #1517