Raise ValueError if method contains control characters #1800
+27
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquentin
reviewed
Feb 15, 2020
|
Yeah it's because |
|
The remaining failure is a strange macOS Python 2.7 bug that also happens on master. It claims that it does not find the coverage program. Investigating... |
|
#1802 should fix the issue we're seeing here |
alfredodeza
pushed a commit
to anchore/anchore-cli
that referenced
this pull request
Oct 6, 2020
Fixes vulnerability reported and fixed with: urllib3/urllib3#1800 Signed-off-by: Alfredo Deza <adeza@anchore.com>
alfredodeza
pushed a commit
to anchore/anchore-engine
that referenced
this pull request
Oct 6, 2020
urllib3/urllib3#1800 Relevant changelog section in urllib3: https://github.com/urllib3/urllib3/blob/master/CHANGES.rst#1259-2020-04-16 Same fix in anchore/anchore-cli#130 Signed-off-by: Alfredo Deza <adeza@anchore.com>
zhill
pushed a commit
to zhill/anchore-engine
that referenced
this pull request
Oct 8, 2020
urllib3/urllib3#1800 Relevant changelog section in urllib3: https://github.com/urllib3/urllib3/blob/master/CHANGES.rst#1259-2020-04-16 Same fix in anchore/anchore-cli#130 Signed-off-by: Alfredo Deza <adeza@anchore.com>
Dobatymo
pushed a commit
to Dobatymo/urllib3
that referenced
this pull request
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protects against BPO-39603 which was reported to CPython and Requests. The risk of this being exploited is minimal as attackers will rarely have direct control of the request method, but in that case header injection is possible in
http.client,urllib3andrequests.This change makes that not possible, unfortunately there's not really an exception that fits the bill for this error, but hopefully this situation is rare enough that we don't have to care.