Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<deleted> #1798

Closed
zogzog opened this issue Feb 6, 2020 · 2 comments
Closed

<deleted> #1798

zogzog opened this issue Feb 6, 2020 · 2 comments

Comments

@zogzog
Copy link

zogzog commented Feb 6, 2020 •
edited

No description provided.

@sethmlarson
Copy link
Member

There is definitely an issue with the current HTTPSConnection using the parent class connect() method, however I don't think restoring the old HTTPSConnection.connect() is the solution. The solution IMO is to rename VerifiedHTTPSConnection to HTTPSConnection and rebind the class to the name VerifiedHTTPSConnection so as not to break backwards compatibility.

We should also deprecate the UnverifiedHTTPSConnection name rebind so it can be removed later.

We won't be supporting an HTTPS mode without either certificate verification or a warning to the user.

@sigmavirus24
Copy link
Contributor

We won't be supporting an HTTPS mode without either certificate verification or a warning to the user.

👏

Besides, I believe we documented how to silence the warning as a user.

@zogzog zogzog changed the title Code that uses UnverifiedHTTPSConnection broken by 063d888bc247eb6bd7aedcd32412bbb53c3c6ffb <deleted> Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sigmavirus24 @zogzog @sethmlarson