Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tidelift to documentation and urllib3 branding #1735

Merged
merged 2 commits into from Nov 5, 2019

Conversation

sethmlarson
Copy link
Member

I think it's totally fine to get rid of the major header in our README. Sphinx documentation isn't modified with a banner.

@codecov-io
Copy link

codecov-io commented Nov 5, 2019

Codecov Report

Merging #1735 into master will decrease coverage by 0.65%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1735      +/-   ##
==========================================
- Coverage    99.7%   99.04%   -0.66%     
==========================================
  Files          22       22              
  Lines        2003     1988      -15     
==========================================
- Hits         1997     1969      -28     
- Misses          6       19      +13
Impacted Files Coverage Δ
src/urllib3/contrib/_appengine_environ.py 70% <0%> (-10%) ⬇️
src/urllib3/util/wait.py 93.75% <0%> (-6.25%) ⬇️
src/urllib3/connection.py 93.75% <0%> (-4.2%) ⬇️
src/urllib3/response.py 99.44% <0%> (-0.56%) ⬇️
src/urllib3/util/url.py 99.47% <0%> (-0.02%) ⬇️
src/urllib3/util/timeout.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6996da3...fbd04ec. Read the comment docs.

@sethmlarson sethmlarson merged commit c823dc9 into urllib3:master Nov 5, 2019
@sethmlarson sethmlarson deleted the branding-and-tidelift branch November 5, 2019 15:15
Dobatymo pushed a commit to Dobatymo/urllib3 that referenced this pull request Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants