Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint #1733

Merged
merged 1 commit into from Nov 5, 2019
Merged

Fix lint #1733

merged 1 commit into from Nov 5, 2019

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Nov 5, 2019

#1724 and #1725 added "notPyPy2" at different places. They both succeeded individually, but their merge caused a flake8 lint error. This was noticed by @jalopezsilva in #1679.

@codecov-io
Copy link

codecov-io commented Nov 5, 2019

Codecov Report

Merging #1733 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1733   +/-   ##
======================================
  Coverage    99.7%   99.7%           
======================================
  Files          22      22           
  Lines        2003    2003           
======================================
  Hits         1997    1997           
  Misses          6       6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26528f7...6b7af3b. Read the comment docs.

@sethmlarson sethmlarson merged commit 6996da3 into urllib3:master Nov 5, 2019
@pquentin pquentin deleted the fix-lint branch November 5, 2019 14:25
Dobatymo pushed a commit to Dobatymo/urllib3 that referenced this pull request Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants