travis: install MacPython only once #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Travis macOS base image is documented to include Python: we can use it to run nox instead of installing Python 3 explicitly, which should result in faster builds.
Codecov Report
@@ Coverage Diff @@
## master #1689 +/- ##
=========================================
+ Coverage 98.45% 99.4% +0.94%
=========================================
Files 22 22
Lines 2005 2005
=========================================
+ Hits 1974 1993 +19
+ Misses 31 12 -19
Continue to review full report at Codecov.
|
|
The coverage improves because upload_coverage.sh now succeeds to install coverage in the macOS Python 2.7 build. The real fix is to just use |
|
Thank you @sethmlarson for the quick reviews: they're really helpful! |
|
No problem! :) Thank you for making all these changes. |
Dobatymo
pushed a commit
to Dobatymo/urllib3
that referenced
this pull request
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Travis macOS base image is documented to include Python: we can use
it to run nox instead of installing Python 3 explicitly, which should
result in faster builds.