Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first-class support for Brotli package #1579

Merged
merged 5 commits into from Apr 24, 2019

Conversation

sethmlarson
Copy link
Member

@sethmlarson sethmlarson commented Apr 24, 2019

Because we actually have to do things to support the Brotli package I figure we should test it so we don't regress...

@codecov-io
Copy link

Codecov Report

Merging #1579 into master will decrease coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1579      +/-   ##
==========================================
- Coverage   99.89%   99.62%   -0.27%     
==========================================
  Files          22       22              
  Lines        1873     1864       -9     
==========================================
- Hits         1871     1857      -14     
- Misses          2        7       +5
Impacted Files Coverage Δ
src/urllib3/response.py 99.72% <100%> (-0.28%) ⬇️
src/urllib3/connection.py 97.03% <0%> (-2.97%) ⬇️
src/urllib3/util/url.py 97.93% <0%> (-0.09%) ⬇️
src/urllib3/util/timeout.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff8f721...3a1d6bd. Read the comment docs.

@sethmlarson sethmlarson merged commit 64e413f into urllib3:master Apr 24, 2019
@sethmlarson sethmlarson deleted the google-brotli branch April 24, 2019 12:18
theacodes added a commit to theacodes/urllib3 that referenced this pull request Apr 24, 2019
theacodes added a commit that referenced this pull request Apr 24, 2019

* Fix appveyor config escaping (I think, ugh yaml)

* Attempt to fix appveyor run script and help mac find nox

* Really, AppVeyor?

* Another attempt to get mac and appveyor working.

* Comb in brotli changes from #1579

* Comb in pypy changes from #1576
Dobatymo pushed a commit to Dobatymo/urllib3 that referenced this pull request Mar 16, 2022
Dobatymo pushed a commit to Dobatymo/urllib3 that referenced this pull request Mar 16, 2022

* Fix appveyor config escaping (I think, ugh yaml)

* Attempt to fix appveyor run script and help mac find nox

* Really, AppVeyor?

* Another attempt to get mac and appveyor working.

* Comb in brotli changes from urllib3#1579

* Comb in pypy changes from urllib3#1576
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants