Uninstall oclint to ensure gcc can be brew upgraded

[sethmlarson]

No description provided.

[codecov-io]

Codecov Report

Merging #1464 into master will increase coverage by 17.36%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1464       +/-   ##
===========================================
+ Coverage   82.09%   99.45%   +17.36%     
===========================================
  Files          22       22               
  Lines        2312     1835      -477     
===========================================
- Hits         1898     1825       -73     
+ Misses        414       10      -404

Impacted Files	Coverage Δ
src/urllib3/util/response.py	100% <0%> (+7.69%)	⬆️
src/urllib3/connectionpool.py	100% <0%> (+7.97%)	⬆️
src/urllib3/__init__.py	68.75% <0%> (+11.99%)	⬆️
src/urllib3/connection.py	100% <0%> (+21.12%)	⬆️
src/urllib3/_collections.py	100% <0%> (+21.53%)	⬆️
src/urllib3/util/connection.py	100% <0%> (+26.47%)	⬆️
src/urllib3/response.py	100% <0%> (+27.72%)	⬆️
src/urllib3/util/wait.py	100% <0%> (+28.08%)	⬆️
src/urllib3/poolmanager.py	100% <0%> (+30.39%)	⬆️
src/urllib3/util/ssl_.py	100% <0%> (+32.87%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd7cfa6...509548b. Read the comment docs.

[pquentin]

I think the fix is brew cask uninstall oclint: travis-ci/travis-ci#8826. The gdal issue is only a warning, not an error.

[sethmlarson]

Thanks @pquentin! I'm very much in the dark about macOS and Homebrew. How'd you go about debugging this particular issue so I can learn to do so better in the future?

[pquentin]

The steps I followed:

• Looking at a failing macOS build such as: https://travis-ci.org/urllib3/urllib3/jobs/445273967

• Grep for "error:", see that the only error is:

    ==> Installing gdal dependency: gcc
    ==> Downloading https://homebrew.bintray.com/bottles/gcc-8.2.0.high_sierra.bottl
    ######################################################################## 100.0%
    ==> Pouring gcc-8.2.0.high_sierra.bottle.1.tar.gz
    Error: The `brew link` step did not complete successfully
    The formula built, but is not symlinked into /usr/local
    Could not symlink include/c++
    Target /usr/local/include/c++
    already exists. You may want to remove it:
      rm '/usr/local/include/c++'
    To force the link and overwrite all conflicting files:
      brew link --overwrite gcc
    To list all files that would be deleted:
      brew link --overwrite --dry-run gcc
    Possible conflicting files are:
    /usr/local/include/c++ -> /usr/local/Caskroom/oclint/0.13.1,17.4.0/oclint-0.13.1/include/c++
  

• Notice the last line, which says oclint conflicts (Caskroom is where homebrew installs packages)

• Search for travis homebrew oclint gcc, and find the travis github issue above which suggests uninstalling oclint first

Does that make sense?

[sethmlarson]

Totally missed the name of the other package in the conflicting files error. I'll know what to look for next time. :)