Restore context.set_ciphers() to create_urllib3_context() #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethmlarson
changed the title
pquentin
approved these changes
Oct 23, 2018
nateprewitt
approved these changes
Oct 23, 2018
Codecov Report
@@ Coverage Diff @@
## master #1463 +/- ##
==========================================
- Coverage 99.45% 98.49% -0.97%
==========================================
Files 22 22
Lines 1835 1857 +22
==========================================
+ Hits 1825 1829 +4
- Misses 10 28 +18
Continue to review full report at Codecov.
|
|
Looks like gdal has gcc as a dependency now (it didn't in previous installs) and is failing because gcc is already installed on the system and it can't overwrite it? |
…MichaelLarson-patch-1
sethmlarson
force-pushed
the
SethMichaelLarson-patch-1
branch
from
fc8e77a
to
6e2d616
Compare
pquentin
approved these changes
Oct 26, 2018
test/test_ssl.py
Outdated
|
|
||
| assert context.set_ciphers.call_count == 1 | ||
| assert context.set_ciphers.call_args == mock.call(expected_ciphers) | ||
|
|
There was a problem hiding this comment.
It looks like CI is failing because of this empty line.
theacodes
approved these changes
Nov 1, 2018
|
Thanks Thea, I'd say we're release-ready now. |
This was referenced Mar 9, 2021
This was referenced Mar 16, 2021
Closed
Dobatymo
pushed a commit
to Dobatymo/urllib3
that referenced
this pull request
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1462.