Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PoolManager does not allow custom server_hostname #1447

Closed
swg0101 opened this issue Oct 3, 2018 · 2 comments
Closed

PoolManager does not allow custom server_hostname #1447

swg0101 opened this issue Oct 3, 2018 · 2 comments
Labels
TLS

Comments

@swg0101
Copy link
Contributor

swg0101 commented Oct 3, 2018

I am trying to pass a custom SNI string on the Python requests module, but it doesn't look like I can create a PoolManager with a custom server_hostname via **pool_kw because it's not defined inside _key_fields in PoolManager.

Is this intended behavior?
@sethmlarson sethmlarson added the TLS label Oct 7, 2018
@swg0101
Copy link
Contributor Author

swg0101 commented Oct 12, 2018

PR here: #1449

@swg0101
Copy link
Contributor Author

swg0101 commented Oct 12, 2018

Thanks Seth!

@swg0101 swg0101 closed this as completed Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
TLS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@swg0101 @sethmlarson