New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove more Python 2.6 code #1430
Conversation
See urllib3/urllib3#1422 for details.
Codecov Report
@@ Coverage Diff @@
## master #1430 +/- ##
======================================
Coverage 100% 100%
======================================
Files 21 21
Lines 1790 1790
======================================
Hits 1790 1790
Continue to review full report at Codecov.
|
Added two possible Windows errors in test_client_no_intermediate, per #1422 (comment). |
It looks like this job failed due to a timeout in Travis itself: https://travis-ci.org/urllib3/urllib3/jobs/420006959. |
0187386
to
5a8ab59
Compare
Thanks @pquentin! 🎉 |
This broke urllib3 on Google App Engine, which also doesn't have Below is a stacktrace of the error. Note that this is pure urllib3, no requests are being used.
|
Oh. Can you please open a pull request to fix that? Thanks! |
…on. Make sure we check for that. urllib3#1503. Not this reverts part of the change in urllib3#1430.
…on. Make sure we check for that. urllib3#1503. Not this reverts part of the change in urllib3#1430.
This also fixes an installation error of gcp-devrel-py-tools==0.0.15, see GoogleCloudPlatform/python-repo-tools#23 for details. I can separate that in two PRs if needed.