Move urllib3 to src/urllib3 #1409
Conversation
When tests are outside the main package, tox recommends putting the main package under an 'src' directory to ensure that the installed package is tested, not the source[0] . This layout has other benefits, too. [1] [0]: https://docs.pytest.org/en/latest/goodpractices.html [1]: https://blog.ionelmc.ro/2014/05/25/python-packaging/#the-structure
|
SecureTransport failure on Python 3.7: https://travis-ci.org/urllib3/urllib3/jobs/399539365, trying again. |
|
Now a TestHTTPS.test_client_no_intermediate failure on Python 2.6 on macOS: https://travis-ci.org/urllib3/urllib3/jobs/399564364, trying again. |
|
I'm generally in favor of this.... once tests pass of course :) |
|
Now a TestHTTPS.test_client_no_intermediate failure on Python 3.4 on Windows: https://ci.appveyor.com/project/urllib3/urllib3/build/1.0.176/job/tenbr6b2hj4crfbg. Trying again! |
|
Yay, all tests pass! I've seen those failures before: I don't think they're related to this change. |
|
Oh, no, they don't actually pass. This time it's three macOS failures, two TestHTTPS.test_client_no_intermediate and one TestSocketClosing.test_delayed_body_read_timeout. |
|
Sorry for the noise, but I think it's useful to know what tests are flaky? Or maybe I should focus on fixing test_client_no_intermediate. The latest failure? TestHTTPS.test_client_no_intermediate on macOS and Python 3.7: https://travis-ci.org/urllib3/urllib3/jobs/399606514. |
|
If you could fix |
Move urllib3 to src/urllib3
When tests are outside the main package, tox recommends putting the main package under an 'src' directory to ensure that the installed package is tested, not the source. This layout has other benefits, too.
We actually ran into this issue in the async support branch: the installation step adds the sync version by removing async/await keywords, so that's the only way to make tox work in that branch.
cc @njsmith