From 7d2419b74c565c9cc0750f607f7e29fa8f058c45 Mon Sep 17 00:00:00 2001 From: Quentin Pradet Date: Tue, 29 Oct 2019 14:22:04 +0400 Subject: [PATCH] Test that chunked=True is preserved on retries --- .../with_dummyserver/test_chunked_transfer.py | 24 ++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/test/with_dummyserver/test_chunked_transfer.py b/test/with_dummyserver/test_chunked_transfer.py index a7512cef69..6e95636b89 100644 --- a/test/with_dummyserver/test_chunked_transfer.py +++ b/test/with_dummyserver/test_chunked_transfer.py @@ -1,7 +1,8 @@ # -*- coding: utf-8 -*- from urllib3 import HTTPConnectionPool -from dummyserver.testcase import SocketDummyServerTestCase +from urllib3.util.retry import Retry +from dummyserver.testcase import SocketDummyServerTestCase, consume_socket class TestChunkedTransfer(SocketDummyServerTestCase): @@ -100,3 +101,24 @@ def test_provides_default_host_header(self): host_headers = [x for x in header_lines if x.startswith(b"host")] assert len(host_headers) == 1 + + def test_preserve_chunked_on_retry(self): + self.chunked_requests = 0 + + def socket_handler(listener): + for _ in range(2): + sock = listener.accept()[0] + request = consume_socket(sock) + if b"Transfer-Encoding: chunked" in request: + self.chunked_requests += 1 + + sock.send(b"HTTP/1.1 404 Not Found\r\n\r\n") + sock.close() + + self._start_server(socket_handler) + with HTTPConnectionPool(self.host, self.port) as pool: + retries = Retry(total=1, raise_on_status=False, status_forcelist=[404]) + pool.urlopen( + "GET", "/", chunked=True, preload_content=False, retries=retries + ) + assert self.chunked_requests == 2