From 3e65ba85a0f129b17baa6ccdb5d98afd53432bfd Mon Sep 17 00:00:00 2001 From: Lynn Cyrin Date: Sun, 17 Nov 2019 13:14:22 -0800 Subject: [PATCH 1/5] v1 and v2 releases --- docs/CHANGELOG.md | 29 ++++++++++++++++++++++++----- 1 file changed, 24 insertions(+), 5 deletions(-) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 9302459666..709fcffba4 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -2,8 +2,14 @@ **ATTN**: This project uses [semantic versioning](http://semver.org/). -## 2.0.0 - (unreleased 2.x series) +## Unreleased - 2.X series + +View [unreleaseed 2.X] series changes. + +## [2.0.0] - 2019-11-17 + ### Added + - `NewStringSlice` and `NewIntSlice` for creating their related types - `Float64SliceFlag` for unmarshaling a list of floats from the user - `Context.Lineage` to get all contexts from current up to global @@ -11,11 +17,13 @@ - `BoolFlag.Value` to handle both default-false and default-true ### Changed + - `Context.FlagNames` now returns all flags in the context lineage - `Context.IsSet` now considers the full context lineage - Added `IsSet` method to the `Flag` interface which allows us to detect whether or not a flag has been set ### Removed + - the ability to specify `&StringSlice{...string}` or `&IntSlice{...int}`. - adapter code for deprecated `Action` func signature - deprecated `App.Author`, `App.Email`, and `Command.ShortName` fields @@ -24,12 +32,19 @@ - `Context.Parent` method, as this is now available via `Context.Lineage` - `BoolTFlag` and related code, as this is now available via `BoolFlag.Value` -## [Unreleased] - (1.x series) -### Added +## Unreleased - 1.22.X series + +View [unreleaseed 1.22.X] series changes. + +## [1.22.2] - 2019-11-17 + +### Fixed + +- TODO ### Changed -### Removed +* TODO ## [1.22.1] - 2019-09-11 @@ -497,7 +512,11 @@ signature of `func(*cli.Context) error`, as defined by `cli.ActionFunc`. ### Added - Initial implementation. -[Unreleased]: https://github.com/urfave/cli/compare/v1.22.1...HEAD +[unreleaseed 2.X]: https://github.com/urfave/cli/compare/v2.0.0...HEAD +[2.0.0]: https://github.com/urfave/cli/compare/v1.22.2...v2.0.0 + +[unreleaseed 1.22.X]: https://github.com/urfave/cli/compare/v1.22.2...v1 +[1.22.2]: https://github.com/urfave/cli/compare/v1.22.1...v1.22.2 [1.22.1]: https://github.com/urfave/cli/compare/v1.22.0...v1.22.1 [1.22.0]: https://github.com/urfave/cli/compare/v1.21.0...v1.22.0 [1.21.0]: https://github.com/urfave/cli/compare/v1.20.0...v1.21.0 From ec54507fa2023d0e2cb871076e100ca47fc36976 Mon Sep 17 00:00:00 2001 From: Lynn Cyrin Date: Sun, 17 Nov 2019 20:39:40 -0800 Subject: [PATCH 2/5] typos --- docs/CHANGELOG.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 709fcffba4..d8915cccc1 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -4,7 +4,7 @@ ## Unreleased - 2.X series -View [unreleaseed 2.X] series changes. +View [unreleased 2.X] series changes. ## [2.0.0] - 2019-11-17 @@ -34,7 +34,7 @@ View [unreleaseed 2.X] series changes. ## Unreleased - 1.22.X series -View [unreleaseed 1.22.X] series changes. +View [unreleased 1.22.X] series changes. ## [1.22.2] - 2019-11-17 @@ -512,10 +512,10 @@ signature of `func(*cli.Context) error`, as defined by `cli.ActionFunc`. ### Added - Initial implementation. -[unreleaseed 2.X]: https://github.com/urfave/cli/compare/v2.0.0...HEAD +[unreleased 2.X]: https://github.com/urfave/cli/compare/v2.0.0...HEAD [2.0.0]: https://github.com/urfave/cli/compare/v1.22.2...v2.0.0 -[unreleaseed 1.22.X]: https://github.com/urfave/cli/compare/v1.22.2...v1 +[unreleased 1.22.X]: https://github.com/urfave/cli/compare/v1.22.2...v1 [1.22.2]: https://github.com/urfave/cli/compare/v1.22.1...v1.22.2 [1.22.1]: https://github.com/urfave/cli/compare/v1.22.0...v1.22.1 [1.22.0]: https://github.com/urfave/cli/compare/v1.21.0...v1.22.0 From 645bbb6478a57db8fc35912d4e719d22c71f215a Mon Sep 17 00:00:00 2001 From: Lynn Cyrin Date: Sun, 17 Nov 2019 22:13:19 -0800 Subject: [PATCH 3/5] v1 changelog --- docs/CHANGELOG.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index d8915cccc1..0c6dda9e5d 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -40,11 +40,15 @@ View [unreleased 1.22.X] series changes. ### Fixed -- TODO +- Fix v1.21.0 pass through regression in [urfave/cli/pull/872](https://github.com/urfave/cli/pull/872) via [@lynncyrin](https://github.com/lynncyrin) +- Fix infinite loop when parsing invalid flags for apps with short option handling in [urfave/cli/pull/911](https://github.com/urfave/cli/pull/911) via [@rliebz](https://github.com/rliebz) +- Fix zsh autocomplete in [urfave/cli/pull/906](https://github.com/urfave/cli/pull/906) via [@gnowxilef](https://github.com/gnowxilef) +- Fix typo in `DocGenerationFlag.TakesValue()` docstring in [urfave/cli/pull/902](https://github.com/urfave/cli/pull/902) via [@benmoose](https://github.com/benmoose) +- Avoid panic for missing flag value in [urfave/cli/pull/893](https://github.com/urfave/cli/pull/893) via [@rliebz](https://github.com/rliebz) ### Changed -* TODO +- Simplify `HelpPrinter` and `CustomHelpPrinter` behaviors in [urfave/cli/pull/912](https://github.com/urfave/cli/pull/912) via [@rliebz](https://github.com/rliebz) ## [1.22.1] - 2019-09-11 From d301b5a608166a3dbbbeca85efb08b57689c1384 Mon Sep 17 00:00:00 2001 From: Lynn Cyrin Date: Sun, 17 Nov 2019 22:23:03 -0800 Subject: [PATCH 4/5] v2 credits --- docs/CHANGELOG.md | 43 +++++++++++++++++++++++++++++++------------ 1 file changed, 31 insertions(+), 12 deletions(-) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 0c6dda9e5d..2a8acf426a 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -8,29 +8,48 @@ View [unreleased 2.X] series changes. ## [2.0.0] - 2019-11-17 +The V2 changes were all shipped in [urfave/cli/pull/892](https://github.com/urfave/cli/pull/892), which was created with the effort of over a dozen participants! They are: + +- [@asahasrabuddhe](https://github.com/asahasrabuddhe) +- [@meatballhat](https://github.com/meatballhat) +- [@jszwedko](https://github.com/jszwedko) +- [@lynncyrin](https://github.com/lynncyrin) +- [@AudriusButkevicius](https://github.com/AudriusButkevicius) +- [@saschagrunert](https://github.com/saschagrunert) +- [@rliebz](https://github.com/rliebz) +- [@johnweldon](https://github.com/johnweldon) +- [@nlewo](https://github.com/nlewo) +- [@grubernaut](https://github.com/grubernaut) +- [@OneOfOne](https://github.com/OneOfOne) +- [@VMitov](https://github.com/VMitov) +- [@cbranch](https://github.com/cbranch) +- [@marwan-at-work](https://github.com/marwan-at-work) +- [@uudashr](https://github.com/uudashr) +- [@bfreis](https://github.com/bfreis) + ### Added -- `NewStringSlice` and `NewIntSlice` for creating their related types -- `Float64SliceFlag` for unmarshaling a list of floats from the user -- `Context.Lineage` to get all contexts from current up to global -- `Context.LocalFlagNames` to get the flag names from *only* the current context -- `BoolFlag.Value` to handle both default-false and default-true +- Added `NewStringSlice` and `NewIntSlice` for creating their related types +- Added `Float64SliceFlag` for unmarshaling a list of floats from the user +- Added `Context.Lineage` to get all contexts from current up to global +- Added `Context.LocalFlagNames` to get the flag names from *only* the current context +- Added `BoolFlag.Value` to handle both default-false and default-true +- Added `IsSet` method to the `Flag` interface which allows us to detect whether or not a flag has been set ### Changed - `Context.FlagNames` now returns all flags in the context lineage - `Context.IsSet` now considers the full context lineage -- Added `IsSet` method to the `Flag` interface which allows us to detect whether or not a flag has been set ### Removed -- the ability to specify `&StringSlice{...string}` or `&IntSlice{...int}`. -- adapter code for deprecated `Action` func signature -- deprecated `App.Author`, `App.Email`, and `Command.ShortName` fields -- All `Context.Global*` methods, as the non-global versions now traverse up +- Removed the ability to specify `&StringSlice{...string}` or `&IntSlice{...int}`. +- Removed adapter code for deprecated `Action` func signature +- Deprecated `App.Author`, `App.Email`, and `Command.ShortName` fields +- Removed all `Context.Global*` methods, as the non-global versions now traverse up the context lineage automatically. -- `Context.Parent` method, as this is now available via `Context.Lineage` -- `BoolTFlag` and related code, as this is now available via `BoolFlag.Value` +- Removed `Context.Parent` method, as this is now available via `Context.Lineage` +- Removed `BoolTFlag` and related code, as this is now available via `BoolFlag.Value` ## Unreleased - 1.22.X series From cca5dd14d8730f2c06ba5547cef17a2a760c2ae0 Mon Sep 17 00:00:00 2001 From: Lynn Cyrin Date: Sun, 17 Nov 2019 22:25:47 -0800 Subject: [PATCH 5/5] use up less space --- docs/CHANGELOG.md | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 2a8acf426a..9aee16f792 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -10,22 +10,7 @@ View [unreleased 2.X] series changes. The V2 changes were all shipped in [urfave/cli/pull/892](https://github.com/urfave/cli/pull/892), which was created with the effort of over a dozen participants! They are: -- [@asahasrabuddhe](https://github.com/asahasrabuddhe) -- [@meatballhat](https://github.com/meatballhat) -- [@jszwedko](https://github.com/jszwedko) -- [@lynncyrin](https://github.com/lynncyrin) -- [@AudriusButkevicius](https://github.com/AudriusButkevicius) -- [@saschagrunert](https://github.com/saschagrunert) -- [@rliebz](https://github.com/rliebz) -- [@johnweldon](https://github.com/johnweldon) -- [@nlewo](https://github.com/nlewo) -- [@grubernaut](https://github.com/grubernaut) -- [@OneOfOne](https://github.com/OneOfOne) -- [@VMitov](https://github.com/VMitov) -- [@cbranch](https://github.com/cbranch) -- [@marwan-at-work](https://github.com/marwan-at-work) -- [@uudashr](https://github.com/uudashr) -- [@bfreis](https://github.com/bfreis) +[@asahasrabuddhe](https://github.com/asahasrabuddhe), [@meatballhat](https://github.com/meatballhat), [@jszwedko](https://github.com/jszwedko), [@lynncyrin](https://github.com/lynncyrin), [@AudriusButkevicius](https://github.com/AudriusButkevicius), [@saschagrunert](https://github.com/saschagrunert), [@rliebz](https://github.com/rliebz), [@johnweldon](https://github.com/johnweldon), [@nlewo](https://github.com/nlewo), [@grubernaut](https://github.com/grubernaut), [@OneOfOne](https://github.com/OneOfOne), [@VMitov](https://github.com/VMitov), [@cbranch](https://github.com/cbranch), [@marwan-at-work](https://github.com/marwan-at-work), [@uudashr](https://github.com/uudashr), [@bfreis](https://github.com/bfreis) ### Added