Feature:(issue_1090): Add unwrap for ExitCoder #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dokiys
reviewed
Oct 26, 2022
| var err error | ||
|
|
||
| switch e := message.(type) { | ||
| case ErrorFormatter: |
There was a problem hiding this comment.
Is there any difference between this and the default handling?
There was a problem hiding this comment.
Well ErrorFormatter implies that the error message can be formatted dfferently than a "regular" error.
Dokiys
reviewed
Oct 27, 2022
Comment on lines
+106
to
+113
| switch e := message.(type) { | ||
| case ErrorFormatter: | ||
| err = fmt.Errorf("%+v", message) | ||
| case error: | ||
| err = e | ||
| default: | ||
| err = fmt.Errorf("%+v", message) | ||
| } |
There was a problem hiding this comment.
Well ErrorFormatter implies that the error message can be formatted dfferently than a "regular" error.
Buf the handling of ErrorFormatter same as default
There was a problem hiding this comment.
Yes. So what do you suggest be done ? I can collapse the ErrorFormatter into default.
There was a problem hiding this comment.
Actually collapsing ErrorFormatter into default doesnt seem to work. I'm going to leave it as it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #1090
Special notes for your reviewer:
(fill-in or delete this section)
Testing
make test
(fill-in or delete this section)
Release Notes
(REQUIRED)