Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept multi-value input on slice flags (#1241) #1377

Merged
merged 3 commits into from Apr 26, 2022
Merged

Accept multi-value input on slice flags (#1241) #1377

merged 3 commits into from Apr 26, 2022

Conversation

meatballhat
Copy link
Member

What type of PR is this?

  • bug

What this PR does / why we need it:

See #1241

@meatballhat meatballhat added this to the Release 2.4.x milestone Apr 26, 2022
@meatballhat meatballhat requested a review from a team as a code owner April 26, 2022 02:47
dearchap
dearchap approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@dearchap dearchap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent fix. Very comprehensive. Thank you for that

@meatballhat meatballhat merged commit 76418f2 into main Apr 26, 2022
@meatballhat meatballhat deleted the vipally-ally_fix_multi_val branch April 26, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dearchap dearchap dearchap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@meatballhat @dearchap @vipally