show only subcommand flags with bash completion #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schollz
requested review from
saschagrunert and
coilysiren
and removed request for
a team
|
Is this blocked for some reason? |
rliebz
previously approved these changes
Nov 13, 2020
|
@schollz can you add a test case for this? |
coilysiren
requested changes
Jan 27, 2021
Sorry, no I cannot. Feel free to close |
|
This issue or PR has been automatically marked as stale because it has not had recent activity. Please add a comment bumping this if you're still interested in it's resolution! Thanks for your help, please let us know if you need anything else. |
|
Closing this as it has become stale. |
meatballhat
added
kind/bug
meatballhat
added a commit
that referenced
this pull request
Apr 22, 2022
meatballhat
added a commit
that referenced
this pull request
Apr 22, 2022
show only subcommand flags with bash completion (#1186)
dearchap
pushed a commit
to dearchap/cli
that referenced
this pull request
Apr 24, 2022
3 tasks
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
On subcommands the bash completion for flags shows global flags which cannot be used. This change makes sure that only subcommand flags are shown.
Which issue(s) this PR fixes:
Fixes #1184
Special notes for your reviewer:
None.
Testing
I tested the change with my program, croc to see if the subcommands (
croc send --) correctly complete the flags for subcommands.Release Notes