Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic autocompletion #855

Closed
zx8 opened this issue Aug 11, 2019 · 11 comments
Closed

Dynamic autocompletion #855

zx8 opened this issue Aug 11, 2019 · 11 comments
Labels
area/v3 relates to / is being considered for v3 kind/feature describes a code enhancement / feature request status/in-review needs to be reviewed by maintainers before it is accepted
Milestone
Release 2.x

Comments

@zx8
Copy link

zx8 commented Aug 11, 2019

It would be fantastic if we could natively support https://github.com/posener/complete for more dynamic/self-contained autocompletion.

For reference, https://github.com/mitchellh/cli does this.
@coilysiren
Copy link
Member

@zx8 hi! I'm not totally sure what adding this would look like, but it sounds interesting! I would be happy to see a PR for this 🙏

@coilysiren coilysiren added help wanted please help if you can! status/confirmed confirmed to be valid, but work has yet to start kind/feature describes a code enhancement / feature request labels Aug 12, 2019
@zx8
Copy link
Author

zx8 commented Aug 12, 2019 •
edited

I can probably put together a proposal/PR for this myself as I've implemented it before in another library.

That said, I'm slightly confused about the different branches/versions and where to branch off/merge back to? Could you clarify the difference between the following:

  • master
  • v1 (assuming this == master?)
  • v2
  • v3

Thanks!

@coilysiren
Copy link
Member

Create a branch off master, which is v1 yes

@coilysiren coilysiren added status/in-review needs to be reviewed by maintainers before it is accepted and removed help wanted please help if you can! status/confirmed confirmed to be valid, but work has yet to start labels Sep 10, 2019
@coilysiren
Copy link
Member

Dropping this into the status: in review bucket, @urfave/cli please add a 👍 or 👎 to the top post if you're in favor or against this feature being added!

@coilysiren
Copy link
Member

FYI I'm working on a new policy where new feature suggestions need two 👍's before someone starts working on it, so don't stand up a PR for this now @zx8!

I have also proposed via #826 that we not add any new features into v1. Given that nobody but me has chimed in on this issue yet, I'm comfortable moving it to the v2 considerations. After v2 is merged into master, I'll work on grabbing some other maintainers to see if they'd be interested in having this feature 📝

@coilysiren coilysiren added the area/v2 relates to / is being considered for v2 label Sep 16, 2019
@stale
Copy link

stale bot commented Feb 25, 2020

This issue or PR has been automatically marked as stale because it has not had recent activity. Please add a comment bumping this if you're still interested in it's resolution! Thanks for your help, please let us know if you need anything else.

@stale stale bot added the status/stale stale due to the age of it's last update label Feb 25, 2020
@coilysiren
Copy link
Member

Does this overlap with #977 at all?

@stale
Copy link

stale bot commented Feb 26, 2020

This issue or PR has been bumped and is no longer marked as stale! Feel free to bump it again in the future, if it's still relevant.

@stale stale bot removed the status/stale stale due to the age of it's last update label Feb 26, 2020
@stale
Copy link

stale bot commented May 26, 2020

This issue or PR has been automatically marked as stale because it has not had recent activity. Please add a comment bumping this if you're still interested in it's resolution! Thanks for your help, please let us know if you need anything else.

@stale stale bot added the status/stale stale due to the age of it's last update label May 26, 2020
@stale
Copy link

stale bot commented Jun 25, 2020

Closing this as it has become stale.

@stale stale bot closed this as completed Jun 25, 2020
@meatballhat meatballhat reopened this Apr 22, 2022
@meatballhat meatballhat removed the status/stale stale due to the age of it's last update label Apr 22, 2022
@dearchap dearchap added area/v3 relates to / is being considered for v3 and removed area/v2 relates to / is being considered for v2 labels Oct 30, 2022
@dearchap
Copy link
Contributor

Dynamic autocomplete is already present in 2.x.

@dearchap dearchap closed this as not planned Won't fix, can't repro, duplicate, stale Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/v3 relates to / is being considered for v3 kind/feature describes a code enhancement / feature request status/in-review needs to be reviewed by maintainers before it is accepted
Projects
None yet
Milestone
Release 2.x
Development

No branches or pull requests
4 participants
@meatballhat @dearchap @coilysiren @zx8